From bf12ae861b75521c56366980f548d00462ad16d4 Mon Sep 17 00:00:00 2001
From: Eric Liu <ericyl.us@gmail.com>
Date: Wed, 18 May 2022 18:51:58 -0700
Subject: [PATCH] fix(modal): close button icons should have
 `aria-hidden="true"

---
 src/ComposedModal/ModalHeader.svelte | 6 +++++-
 src/Modal/Modal.svelte               | 4 ++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/ComposedModal/ModalHeader.svelte b/src/ComposedModal/ModalHeader.svelte
index 3386c6cd..f3b5c069 100644
--- a/src/ComposedModal/ModalHeader.svelte
+++ b/src/ComposedModal/ModalHeader.svelte
@@ -56,6 +56,10 @@
     on:click
     on:click="{closeModal}"
   >
-    <Close size="{20}" class="bx--modal-close__icon {closeIconClass}" />
+    <Close
+      size="{20}"
+      class="bx--modal-close__icon {closeIconClass}"
+      aria-hidden="true"
+    />
   </button>
 </div>
diff --git a/src/Modal/Modal.svelte b/src/Modal/Modal.svelte
index 85851023..9efbda6f 100644
--- a/src/Modal/Modal.svelte
+++ b/src/Modal/Modal.svelte
@@ -227,7 +227,7 @@
             open = false;
           }}"
         >
-          <Close size="{20}" class="bx--modal-close__icon" />
+          <Close size="{20}" class="bx--modal-close__icon" aria-hidden="true" />
         </button>
       {/if}
       {#if modalLabel}
@@ -248,7 +248,7 @@
             open = false;
           }}"
         >
-          <Close size="{20}" class="bx--modal-close__icon" />
+          <Close size="{20}" class="bx--modal-close__icon" aria-hidden="true" />
         </button>
       {/if}
     </div>