From c00df4021640c8697a37199ee2feb6348c79a23d Mon Sep 17 00:00:00 2001
From: metonym <ericyl.us@gmail.com>
Date: Sun, 26 Mar 2023 12:28:48 -0700
Subject: [PATCH] chore(a11y): silence new a11y warnings from svelte@3.57
 (#1703)

* chore(deps-dev): upgrade svelte to 3.57

* chore(deps-dev): upgrade svelte-check

* chore(a11y): silence new a11y warnings from svelte@3.57

* Revert "chore(deps-dev): upgrade svelte-check"

This reverts commit 78106587a2fd0e1bb07e86afc9fb49f596d2c24a.

* fix(progress-step): remove unnecessary `aria-disabled`

https://github.com/carbon-design-system/carbon-components-svelte/pull/1703#pullrequestreview-1357928713
---
 docs/package.json                         |  2 +-
 docs/yarn.lock                            | 10 +++++-----
 package.json                              |  2 +-
 src/ContextMenu/ContextMenu.svelte        |  1 +
 src/OverflowMenu/OverflowMenu.svelte      |  1 +
 src/ProgressIndicator/ProgressStep.svelte |  1 -
 src/Tabs/Tabs.svelte                      |  1 +
 src/TreeView/TreeView.svelte              |  1 +
 src/TreeView/TreeViewNode.svelte          |  1 +
 src/TreeView/TreeViewNodeList.svelte      |  1 +
 src/UIShell/HeaderNav.svelte              |  1 +
 src/UIShell/HeaderNavMenu.svelte          |  1 +
 src/UIShell/HeaderSearch.svelte           |  1 +
 src/UIShell/SideNavMenu.svelte            |  1 +
 yarn.lock                                 | 10 +++++-----
 15 files changed, 22 insertions(+), 13 deletions(-)

diff --git a/docs/package.json b/docs/package.json
index 71f0550e..0e44fd58 100644
--- a/docs/package.json
+++ b/docs/package.json
@@ -22,7 +22,7 @@
     "prism-svelte": "^0.4.7",
     "prismjs": "^1.28.0",
     "remark-slug": "^6.0.0",
-    "svelte": "^3.49.0",
+    "svelte": "^3.57.0",
     "vite": "^3.0.9"
   },
   "routify": {
diff --git a/docs/yarn.lock b/docs/yarn.lock
index 60209c7b..894928bd 100644
--- a/docs/yarn.lock
+++ b/docs/yarn.lock
@@ -165,7 +165,7 @@ bufferutil@^4.0.1:
     node-gyp-build "~3.7.0"
 
 carbon-components-svelte@../:
-  version "0.70.1"
+  version "0.73.3"
   dependencies:
     flatpickr "4.6.9"
 
@@ -1280,10 +1280,10 @@ svelte-hmr@^0.14.12:
   resolved "https://registry.yarnpkg.com/svelte-hmr/-/svelte-hmr-0.14.12.tgz#a127aec02f1896500b10148b2d4d21ddde39973f"
   integrity sha512-4QSW/VvXuqVcFZ+RhxiR8/newmwOCTlbYIezvkeN6302YFRE8cXy0naamHcjz8Y9Ce3ITTZtrHrIL0AGfyo61w==
 
-svelte@^3.49.0:
-  version "3.49.0"
-  resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.49.0.tgz#5baee3c672306de1070c3b7888fc2204e36a4029"
-  integrity sha512-+lmjic1pApJWDfPCpUUTc1m8azDqYCG1JN9YEngrx/hUyIcFJo6VZhj0A1Ai0wqoHcEIuQy+e9tk+4uDgdtsFA==
+svelte@^3.57.0:
+  version "3.57.0"
+  resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.57.0.tgz#a3969cfe51f25f2a55e75f7b98dbd02c3af0980b"
+  integrity sha512-WMXEvF+RtAaclw0t3bPDTUe19pplMlfyKDsixbHQYgCWi9+O9VN0kXU1OppzrB9gPAvz4NALuoca2LfW2bOjTQ==
 
 symbol-tree@^3.2.4:
   version "3.2.4"
diff --git a/package.json b/package.json
index 9451373d..3f748ae6 100644
--- a/package.json
+++ b/package.json
@@ -39,7 +39,7 @@
     "sass": "^1.49.11",
     "standard-version": "^9.5.0",
     "sveld": "^0.18.0",
-    "svelte": "^3.51.0",
+    "svelte": "^3.57.0",
     "svelte-check": "^2.8.1",
     "typescript": "^4.7.4"
   },
diff --git a/src/ContextMenu/ContextMenu.svelte b/src/ContextMenu/ContextMenu.svelte
index 68adc47a..80182eb9 100644
--- a/src/ContextMenu/ContextMenu.svelte
+++ b/src/ContextMenu/ContextMenu.svelte
@@ -153,6 +153,7 @@
   }}"
 />
 
+<!-- svelte-ignore a11y-no-noninteractive-element-to-interactive-role -->
 <ul
   bind:this="{ref}"
   role="menu"
diff --git a/src/OverflowMenu/OverflowMenu.svelte b/src/OverflowMenu/OverflowMenu.svelte
index f3c5fd1c..ac7eb896 100644
--- a/src/OverflowMenu/OverflowMenu.svelte
+++ b/src/OverflowMenu/OverflowMenu.svelte
@@ -242,6 +242,7 @@
     />
   </slot>
   {#if open}
+    <!-- svelte-ignore a11y-no-noninteractive-element-to-interactive-role -->
     <ul
       bind:this="{menuRef}"
       role="menu"
diff --git a/src/ProgressIndicator/ProgressStep.svelte b/src/ProgressIndicator/ProgressStep.svelte
index 57446ff2..09ae7c91 100644
--- a/src/ProgressIndicator/ProgressStep.svelte
+++ b/src/ProgressIndicator/ProgressStep.svelte
@@ -53,7 +53,6 @@
 
 <!-- svelte-ignore a11y-mouse-events-have-key-events -->
 <li
-  aria-disabled="{disabled}"
   id="{id}"
   class:bx--progress-step="{true}"
   class:bx--progress-step--current="{current}"
diff --git a/src/Tabs/Tabs.svelte b/src/Tabs/Tabs.svelte
index 73564a40..987abbba 100644
--- a/src/Tabs/Tabs.svelte
+++ b/src/Tabs/Tabs.svelte
@@ -151,6 +151,7 @@
     </a>
     <ChevronDown aria-hidden="true" title="{iconDescription}" />
   </div>
+  <!-- svelte-ignore a11y-no-noninteractive-element-to-interactive-role -->
   <ul
     bind:this="{refTabList}"
     role="tablist"
diff --git a/src/TreeView/TreeView.svelte b/src/TreeView/TreeView.svelte
index c968ea32..c1aaaa42 100644
--- a/src/TreeView/TreeView.svelte
+++ b/src/TreeView/TreeView.svelte
@@ -188,6 +188,7 @@
   </label>
 {/if}
 
+<!-- svelte-ignore a11y-no-noninteractive-element-to-interactive-role -->
 <ul
   {...$$restProps}
   role="tree"
diff --git a/src/TreeView/TreeViewNode.svelte b/src/TreeView/TreeViewNode.svelte
index ffcd4ad1..6b641576 100644
--- a/src/TreeView/TreeViewNode.svelte
+++ b/src/TreeView/TreeViewNode.svelte
@@ -75,6 +75,7 @@
   }
 </script>
 
+<!-- svelte-ignore a11y-no-noninteractive-element-to-interactive-role -->
 <li
   bind:this="{ref}"
   role="treeitem"
diff --git a/src/TreeView/TreeViewNodeList.svelte b/src/TreeView/TreeViewNodeList.svelte
index b5d01e87..0ef85ac3 100644
--- a/src/TreeView/TreeViewNodeList.svelte
+++ b/src/TreeView/TreeViewNodeList.svelte
@@ -72,6 +72,7 @@
     {/if}
   {/each}
 {:else}
+  <!-- svelte-ignore a11y-no-noninteractive-element-to-interactive-role -->
   <li
     bind:this="{ref}"
     role="treeitem"
diff --git a/src/UIShell/HeaderNav.svelte b/src/UIShell/HeaderNav.svelte
index 91142f4a..2c86579c 100644
--- a/src/UIShell/HeaderNav.svelte
+++ b/src/UIShell/HeaderNav.svelte
@@ -6,6 +6,7 @@
 </script>
 
 <nav {...props} class:bx--header__nav="{true}" {...$$restProps}>
+  <!-- svelte-ignore a11y-no-noninteractive-element-to-interactive-role -->
   <ul {...props} role="menubar" class:bx--header__menu-bar="{true}">
     <slot />
   </ul>
diff --git a/src/UIShell/HeaderNavMenu.svelte b/src/UIShell/HeaderNavMenu.svelte
index 7e847422..4309bec0 100644
--- a/src/UIShell/HeaderNavMenu.svelte
+++ b/src/UIShell/HeaderNavMenu.svelte
@@ -94,6 +94,7 @@
     {text}
     <ChevronDown class="bx--header__menu-arrow" />
   </a>
+  <!-- svelte-ignore a11y-no-noninteractive-element-to-interactive-role -->
   <ul
     bind:this="{menuRef}"
     role="menu"
diff --git a/src/UIShell/HeaderSearch.svelte b/src/UIShell/HeaderSearch.svelte
index a1ca9c15..a45a4199 100644
--- a/src/UIShell/HeaderSearch.svelte
+++ b/src/UIShell/HeaderSearch.svelte
@@ -134,6 +134,7 @@
   </div>
 
   {#if active && results.length > 0}
+    <!-- svelte-ignore a11y-no-noninteractive-element-to-interactive-role -->
     <ul aria-labelledby="search-label" role="menu" id="search-menu">
       {#each results as result, i}
         <li role="none">
diff --git a/src/UIShell/SideNavMenu.svelte b/src/UIShell/SideNavMenu.svelte
index 12008482..98502554 100644
--- a/src/UIShell/SideNavMenu.svelte
+++ b/src/UIShell/SideNavMenu.svelte
@@ -48,6 +48,7 @@
       <ChevronDown />
     </div>
   </button>
+  <!-- svelte-ignore a11y-no-noninteractive-element-to-interactive-role -->
   <ul
     role="menu"
     class:bx--side-nav__menu="{true}"
diff --git a/yarn.lock b/yarn.lock
index 9ac0450f..0fee6db6 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -2018,16 +2018,16 @@ svelte-preprocess@^4.10.6:
     sorcery "^0.10.0"
     strip-indent "^3.0.0"
 
-svelte@^3.51.0:
-  version "3.51.0"
-  resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.51.0.tgz#a1a0afb25dc518217f353dd73ea6471c128ddf84"
-  integrity sha512-PBITYIrsNOuW+Dtds00gSY68raNZQn7i59Dg/fjgf6WwyawPKeBwle692coO7ILZqSO+UJe9899aDn9sMdeOHA==
-
 svelte@^3.52.0:
   version "3.54.0"
   resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.54.0.tgz#b4bcd865bd9e927f9f7b76563288ef5f4d72867a"
   integrity sha512-tdrgeJU0hob0ZWAMoKXkhcxXA7dpTg6lZGxUeko5YqvPdJBiyRspGsCwV27kIrbrqPP2WUoSV9ca0gnLlw8YzQ==
 
+svelte@^3.57.0:
+  version "3.57.0"
+  resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.57.0.tgz#a3969cfe51f25f2a55e75f7b98dbd02c3af0980b"
+  integrity sha512-WMXEvF+RtAaclw0t3bPDTUe19pplMlfyKDsixbHQYgCWi9+O9VN0kXU1OppzrB9gPAvz4NALuoca2LfW2bOjTQ==
+
 terser@^5.0.0:
   version "5.14.2"
   resolved "https://registry.yarnpkg.com/terser/-/terser-5.14.2.tgz#9ac9f22b06994d736174f4091aa368db896f1c10"