mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-15 02:11:05 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix: resolve a11y warnings from Svelte version 3.58 (#1732)

Browse source 
* chore(deps-dev): upgrade svelte to 3.58

* chore(a11y): ignore false positives

Referencing the upstream Carbon React implementation, these warnings can be ignored.

* fix(list-box-menu-item): set `tabindex` to `-1`

* chore: fix `tabindex` capitalization

The Svelte Language server does not detect `tabIndex` as a valid attribute.

Note, however, that `tabIndex` is correct when using it in JavaScript (e.g., `node.tabIndex`).
This commit is contained in:
Eric Liu 2023-05-18 11:53:17 -07:00 • committed by GitHub
commit c02b4738bc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 16 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/ListBox/ListBoxSelection.svelte
View file

@ -62,7 +62,7 @@
<div
bind:this="{ref}"
role="button"
tabIndex="{disabled ? -1 : 0}"
tabindex="{disabled ? -1 : 0}"
class:bx--tag__close-icon="{true}"
on:click|preventDefault|stopPropagation="{(e) => {
if (!disabled) {