From 1286b9901d846a8c0232bb1cd5cf01b3fe36d70a Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Sun, 22 Dec 2019 09:29:45 -0800 Subject: [PATCH] refactor(components): remove exported "props" Closes #17 - Forward events - Adds style prop, removes exported props --- .../Accordion/Accordion.Skeleton.svelte | 1 - src/components/Accordion/Accordion.svelte | 4 ++- src/components/Accordion/AccordionItem.svelte | 4 +-- .../Breadcrumb/Breadcrumb.Skeleton.svelte | 4 +-- src/components/Breadcrumb/Breadcrumb.svelte | 10 +++++- .../Breadcrumb/BreadcrumbItem.svelte | 9 +++-- src/components/Button/Button.Skeleton.svelte | 8 +++-- src/components/Button/Button.svelte | 10 +++--- src/components/CodeSnippet/CodeSnippet.svelte | 35 +++++++++++-------- src/components/Copy/Copy.svelte | 4 ++- src/components/CopyButton/CopyButton.svelte | 4 ++- src/components/Form/Form.svelte | 2 +- src/components/FormGroup/FormGroup.svelte | 9 ++++- src/components/FormItem/FormItem.svelte | 2 +- src/components/FormLabel/FormLabel.svelte | 2 +- .../InlineLoading/InlineLoading.Story.svelte | 9 +---- .../InlineLoading/InlineLoading.stories.js | 19 ++++------ .../InlineLoading/InlineLoading.svelte | 7 ++-- src/components/Link/Link.svelte | 10 +++--- src/components/ListItem/ListItem.svelte | 4 +-- src/components/Loading/Loading.svelte | 10 +++--- src/components/OrderedList/OrderedList.svelte | 4 +-- src/components/Search/Search.Skeleton.svelte | 4 +-- src/components/Search/Search.svelte | 16 ++++----- .../SkeletonText/SkeletonText.svelte | 4 +-- src/components/Tag/Tag.Skeleton.svelte | 8 ++++- src/components/Tag/Tag.svelte | 8 ++--- .../TextArea/TextArea.Skeleton.svelte | 4 +-- src/components/TextArea/TextArea.svelte | 5 ++- src/components/TextInput/TextInput.svelte | 1 + .../UnorderedList/UnorderedList.svelte | 4 +-- 31 files changed, 120 insertions(+), 105 deletions(-) diff --git a/src/components/Accordion/Accordion.Skeleton.svelte b/src/components/Accordion/Accordion.Skeleton.svelte index 2cd156ff..0ed47b1b 100644 --- a/src/components/Accordion/Accordion.Skeleton.svelte +++ b/src/components/Accordion/Accordion.Skeleton.svelte @@ -27,7 +27,6 @@ {/if} - {#each skeletonItems as item}
  • diff --git a/src/components/Accordion/Accordion.svelte b/src/components/Accordion/Accordion.svelte index f4307f99..647341e6 100644 --- a/src/components/Accordion/Accordion.svelte +++ b/src/components/Accordion/Accordion.svelte @@ -4,8 +4,10 @@ export let style = undefined; import { cx } from '../../lib'; + + const _class = cx('--accordion', className); -
      +
      diff --git a/src/components/Accordion/AccordionItem.svelte b/src/components/Accordion/AccordionItem.svelte index 55aae9a1..5af8e387 100644 --- a/src/components/Accordion/AccordionItem.svelte +++ b/src/components/Accordion/AccordionItem.svelte @@ -20,12 +20,12 @@
    • { animation = undefined; - }}> + }} + {style}> {/if} diff --git a/src/components/Copy/Copy.svelte b/src/components/Copy/Copy.svelte index 06fb1cf5..c91ffb53 100644 --- a/src/components/Copy/Copy.svelte +++ b/src/components/Copy/Copy.svelte @@ -3,6 +3,7 @@ export { className as class }; export let feedback = 'Copied!'; export let feedbackTimeout = 2000; + export let style = undefined; import { onDestroy } from 'svelte'; import { cx } from '../../lib'; @@ -32,7 +33,8 @@ }} on:mouseover on:mouseenter - on:mouseleave> + on:mouseleave + {style}>
      diff --git a/src/components/CopyButton/CopyButton.svelte b/src/components/CopyButton/CopyButton.svelte index 3aa2d991..39e27ae7 100644 --- a/src/components/CopyButton/CopyButton.svelte +++ b/src/components/CopyButton/CopyButton.svelte @@ -4,6 +4,7 @@ export let iconDescription = 'Copy to clipboard'; export let feedback = 'Copied!'; export let feedbackTimeout = 2000; + export let style = undefined; import { onDestroy } from 'svelte'; import Copy16 from 'carbon-icons-svelte/lib/Copy16'; @@ -49,7 +50,8 @@ if (animationName === 'hide-feedback') { animation = undefined; } - }}> + }} + {style}> {feedback} diff --git a/src/components/Form/Form.svelte b/src/components/Form/Form.svelte index c955b205..55ac04cf 100644 --- a/src/components/Form/Form.svelte +++ b/src/components/Form/Form.svelte @@ -8,6 +8,6 @@ const _class = cx('--form', className); -
      + diff --git a/src/components/FormGroup/FormGroup.svelte b/src/components/FormGroup/FormGroup.svelte index 20c7a676..ca957ce3 100644 --- a/src/components/FormGroup/FormGroup.svelte +++ b/src/components/FormGroup/FormGroup.svelte @@ -13,7 +13,14 @@ const _legendClass = cx('--label', className); -
      +
      {legendText} {#if message} diff --git a/src/components/FormItem/FormItem.svelte b/src/components/FormItem/FormItem.svelte index e178f999..3fcfc670 100644 --- a/src/components/FormItem/FormItem.svelte +++ b/src/components/FormItem/FormItem.svelte @@ -8,6 +8,6 @@ const _class = cx('--form-item', className); -
      +
      diff --git a/src/components/FormLabel/FormLabel.svelte b/src/components/FormLabel/FormLabel.svelte index 5a7c0dbf..c5ee75e6 100644 --- a/src/components/FormLabel/FormLabel.svelte +++ b/src/components/FormLabel/FormLabel.svelte @@ -9,6 +9,6 @@ const _class = cx('--form-item', className); -