refactor(components): convert const to reactive where appropriate

- Inline class assignments to avoid script-level clutter
- Ignore a11y-missing-attribute instead of redundant href
This commit is contained in:
Eric Liu 2019-12-24 09:41:12 -08:00
commit c446fc74f4
94 changed files with 469 additions and 598 deletions

View file

@ -5,28 +5,22 @@
export let style = undefined;
import { cx } from '../../lib';
const _class = cx(
'--snippet',
'--skeleton',
type === 'single' && '--snippet--single',
type === 'multi' && '--snippet--multi',
className
);
</script>
{#if type === 'single'}
<div on:click on:mouseover on:mouseenter on:mouseleave {style} class={_class}>
<div class={cx('--snippet-container')}>
<div
on:click
on:mouseover
on:mouseenter
on:mouseleave
class={cx('--snippet', '--skeleton', type === 'single' && '--snippet--single', type === 'multi' && '--snippet--multi', className)}
{style}>
<div class={cx('--snippet-container')}>
{#if type === 'single'}
<span />
</div>
{:else if type === 'multi'}
<span />
<span />
<span />
{/if}
</div>
{:else if type === 'multi'}
<div on:click on:mouseover on:mouseenter on:mouseleave {style} class={_class}>
<div class={cx('--snippet-container')}>
<span />
<span />
<span />
</div>
</div>
{/if}
</div>

View file

@ -26,14 +26,6 @@
$: if (codeRef) {
showMoreLess = type === 'multi' && codeRef.getBoundingClientRect().height > 255;
}
$: _class = cx(
'--snippet',
type && `--snippet--${type}`,
type === 'inline' && '--btn--copy',
expanded && '--snippet--expand',
light && '--snippet--light',
className
);
</script>
{#if type === 'inline'}
@ -44,7 +36,7 @@
on:mouseover
on:mouseenter
on:mouseleave
class={_class}
class={cx('--snippet', type && `--snippet--${type}`, type === 'inline' && '--btn--copy', expanded && '--snippet--expand', light && '--snippet--light', className)}
{feedback}
{feedbackTimeout}
{style}>
@ -53,7 +45,13 @@
</code>
</Copy>
{:else}
<div on:click on:mouseover on:mouseenter on:mouseleave class={_class} {style}>
<div
on:click
on:mouseover
on:mouseenter
on:mouseleave
class={cx('--snippet', type && `--snippet--${type}`, type === 'inline' && '--btn--copy', expanded && '--snippet--expand', light && '--snippet--light', className)}
{style}>
<div
role="textbox"
tabindex="0"