mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-15 10:21:05 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(overflow-menu): add aria-controls to trigger button

Browse source
This commit is contained in:
Eric Liu 2025-02-17 12:01:13 -08:00
commit c5511fcf90
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/OverflowMenu/OverflowMenu.svelte
View file

@ -162,6 +162,7 @@
onMountAfterUpdate = false; onMountAfterUpdate = false;
}); });
$: menuId = `menu-${id}`;
$: ariaLabel = $$props["aria-label"] || "menu"; $: ariaLabel = $$props["aria-label"] || "menu";
$: if ($items[$currentIndex]) { $: if ($items[$currentIndex]) {
focusedId.set($items[$currentIndex].id); focusedId.set($items[$currentIndex].id);
@ -194,6 +195,7 @@
aria-haspopup="true" aria-haspopup="true"
aria-expanded={open} aria-expanded={open}
aria-label={ariaLabel} aria-label={ariaLabel}
aria-controls={open ? menuId : undefined}
{id} {id}
class:bx--overflow-menu={true} class:bx--overflow-menu={true}
class:bx--overflow-menu--open={open} class:bx--overflow-menu--open={open}
@ -239,6 +241,7 @@
bind:this={menuRef} bind:this={menuRef}
role="menu" role="menu"
tabindex="-1" tabindex="-1"
id={menuId}
aria-label={ariaLabel} aria-label={ariaLabel}
data-floating-menu-direction={direction} data-floating-menu-direction={direction}
class:bx--overflow-menu-options={true} class:bx--overflow-menu-options={true}