fix(a11y): ignore false positive a11y warnings (#1522)

Fixes #1517
This commit is contained in:
metonym 2022-10-13 21:37:52 -07:00 committed by GitHub
commit c6373dc9b6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
21 changed files with 24 additions and 5 deletions

View file

@ -39,7 +39,7 @@
"rollup-plugin-terser": "^7.0.2", "rollup-plugin-terser": "^7.0.2",
"sass": "^1.49.11", "sass": "^1.49.11",
"sveld": "^0.17.2", "sveld": "^0.17.2",
"svelte": "^3.50.0", "svelte": "^3.51.0",
"svelte-check": "^2.8.1", "svelte-check": "^2.8.1",
"typescript": "^4.7.4" "typescript": "^4.7.4"
}, },

View file

@ -215,6 +215,7 @@
on:mouseenter on:mouseenter
on:mouseleave on:mouseleave
> >
<!-- svelte-ignore a11y-no-noninteractive-tabindex -->
<div <div
role="{type === 'single' ? 'textbox' : undefined}" role="{type === 'single' ? 'textbox' : undefined}"
tabindex="{type === 'single' && !disabled ? '0' : undefined}" tabindex="{type === 'single' && !disabled ? '0' : undefined}"

View file

@ -150,6 +150,7 @@
} }
}}" }}"
> >
<!-- svelte-ignore a11y-click-events-have-key-events -->
<div <div
bind:this="{innerModal}" bind:this="{innerModal}"
role="dialog" role="dialog"

View file

@ -6,6 +6,7 @@
export let hasScrollingContent = false; export let hasScrollingContent = false;
</script> </script>
<!-- svelte-ignore a11y-no-noninteractive-tabindex -->
<div <div
tabindex="{hasScrollingContent ? '0' : undefined}" tabindex="{hasScrollingContent ? '0' : undefined}"
role="{hasScrollingContent ? 'region' : undefined}" role="{hasScrollingContent ? 'region' : undefined}"

View file

@ -63,6 +63,7 @@
</div> </div>
</section> </section>
{/if} {/if}
<!-- svelte-ignore a11y-click-events-have-key-events -->
<table <table
class:bx--skeleton="{true}" class:bx--skeleton="{true}"
class:bx--data-table="{true}" class:bx--data-table="{true}"

View file

@ -60,6 +60,7 @@
} }
</script> </script>
<!-- svelte-ignore a11y-no-noninteractive-tabindex -->
<label <label
aria-disabled="{disabled}" aria-disabled="{disabled}"
for="{id}" for="{id}"

View file

@ -81,6 +81,7 @@
} }
}}" }}"
> >
<!-- svelte-ignore a11y-no-noninteractive-tabindex -->
<label <label
for="{id}" for="{id}"
tabindex="{tabindex}" tabindex="{tabindex}"

View file

@ -43,6 +43,7 @@
$: menuId = `menu-${id}`; $: menuId = `menu-${id}`;
</script> </script>
<!-- svelte-ignore a11y-no-noninteractive-tabindex -->
<div <div
bind:this="{ref}" bind:this="{ref}"
role="{role}" role="{role}"

View file

@ -243,6 +243,7 @@
</button> </button>
{/if} {/if}
</div> </div>
<!-- svelte-ignore a11y-no-noninteractive-tabindex -->
<div <div
id="{modalBodyId}" id="{modalBodyId}"
class:bx--modal-content="{true}" class:bx--modal-content="{true}"

View file

@ -156,6 +156,7 @@
</script> </script>
<!-- svelte-ignore a11y-mouse-events-have-key-events --> <!-- svelte-ignore a11y-mouse-events-have-key-events -->
<!-- svelte-ignore a11y-click-events-have-key-events -->
<div <div
class:bx--form-item="{true}" class:bx--form-item="{true}"
on:click on:click

View file

@ -101,6 +101,7 @@
class:bx--search--expanded="{expanded}" class:bx--search--expanded="{expanded}"
class="{searchClass}" class="{searchClass}"
> >
<!-- svelte-ignore a11y-click-events-have-key-events -->
<div <div
bind:this="{searchRef}" bind:this="{searchRef}"
class:bx--search-magnifier="{true}" class:bx--search-magnifier="{true}"

View file

@ -12,6 +12,7 @@
<!-- svelte-ignore a11y-mouse-events-have-key-events --> <!-- svelte-ignore a11y-mouse-events-have-key-events -->
{#if label} {#if label}
<!-- svelte-ignore a11y-label-has-associated-control --> <!-- svelte-ignore a11y-label-has-associated-control -->
<!-- svelte-ignore a11y-no-noninteractive-tabindex -->
<label <label
tabindex="{tabindex}" tabindex="{tabindex}"
class:bx--structured-list-row="{true}" class:bx--structured-list-row="{true}"

View file

@ -59,6 +59,7 @@
</script> </script>
<!-- svelte-ignore a11y-mouse-events-have-key-events --> <!-- svelte-ignore a11y-mouse-events-have-key-events -->
<!-- svelte-ignore a11y-click-events-have-key-events -->
<div <div
on:click on:click
on:mouseover on:mouseover

View file

@ -94,6 +94,7 @@
</script> </script>
<!-- svelte-ignore a11y-mouse-events-have-key-events --> <!-- svelte-ignore a11y-mouse-events-have-key-events -->
<!-- svelte-ignore a11y-click-events-have-key-events -->
<div <div
class:bx--form-item="{true}" class:bx--form-item="{true}"
class:bx--text-input-wrapper="{true}" class:bx--text-input-wrapper="{true}"

View file

@ -100,6 +100,7 @@
</script> </script>
<!-- svelte-ignore a11y-mouse-events-have-key-events --> <!-- svelte-ignore a11y-mouse-events-have-key-events -->
<!-- svelte-ignore a11y-click-events-have-key-events -->
<div <div
class:bx--form-item="{true}" class:bx--form-item="{true}"
class:bx--text-input-wrapper="{true}" class:bx--text-input-wrapper="{true}"

View file

@ -53,6 +53,7 @@
disabled="{disabled}" disabled="{disabled}"
/> />
<!-- svelte-ignore a11y-mouse-events-have-key-events --> <!-- svelte-ignore a11y-mouse-events-have-key-events -->
<!-- svelte-ignore a11y-no-noninteractive-tabindex -->
<label <label
for="{id}" for="{id}"
tabindex="{disabled ? undefined : tabindex}" tabindex="{disabled ? undefined : tabindex}"

View file

@ -52,6 +52,7 @@
</script> </script>
<!-- svelte-ignore a11y-mouse-events-have-key-events --> <!-- svelte-ignore a11y-mouse-events-have-key-events -->
<!-- svelte-ignore a11y-click-events-have-key-events -->
<div <div
class:bx--form-item="{true}" class:bx--form-item="{true}"
on:click on:click

View file

@ -249,6 +249,7 @@
on:keydown="{onKeydown}" on:keydown="{onKeydown}"
> >
<span class:bx--tooltip__caret="{true}"></span> <span class:bx--tooltip__caret="{true}"></span>
<!-- svelte-ignore a11y-click-events-have-key-events -->
<div <div
on:click|stopPropagation on:click|stopPropagation
on:mousedown|stopPropagation on:mousedown|stopPropagation

View file

@ -132,6 +132,7 @@
}}" }}"
> >
<div class:bx--tree-node__label="{true}" bind:this="{refLabel}"> <div class:bx--tree-node__label="{true}" bind:this="{refLabel}">
<!-- svelte-ignore a11y-click-events-have-key-events -->
<span <span
class:bx--tree-parent-node__toggle="{true}" class:bx--tree-parent-node__toggle="{true}"
disabled="{disabled}" disabled="{disabled}"

View file

@ -55,6 +55,7 @@
<svelte:window bind:innerWidth="{winWidth}" /> <svelte:window bind:innerWidth="{winWidth}" />
{#if !fixed} {#if !fixed}
<!-- svelte-ignore a11y-click-events-have-key-events -->
<div <div
on:click="{() => { on:click="{() => {
dispatch('click:overlay'); dispatch('click:overlay');

View file

@ -1419,10 +1419,10 @@ svelte@^3.47.0:
resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.49.0.tgz#5baee3c672306de1070c3b7888fc2204e36a4029" resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.49.0.tgz#5baee3c672306de1070c3b7888fc2204e36a4029"
integrity sha512-+lmjic1pApJWDfPCpUUTc1m8azDqYCG1JN9YEngrx/hUyIcFJo6VZhj0A1Ai0wqoHcEIuQy+e9tk+4uDgdtsFA== integrity sha512-+lmjic1pApJWDfPCpUUTc1m8azDqYCG1JN9YEngrx/hUyIcFJo6VZhj0A1Ai0wqoHcEIuQy+e9tk+4uDgdtsFA==
svelte@^3.50.0: svelte@^3.51.0:
version "3.50.0" version "3.51.0"
resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.50.0.tgz#d11a7a6bd1e084ec051d55104a9af8bccf54461f" resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.51.0.tgz#a1a0afb25dc518217f353dd73ea6471c128ddf84"
integrity sha512-zXeOUDS7+85i+RxLN+0iB6PMbGH7OhEgjETcD1fD8ZrhuhNFxYxYEHU41xuhkHIulJavcu3PKbPyuCrBxdxskQ== integrity sha512-PBITYIrsNOuW+Dtds00gSY68raNZQn7i59Dg/fjgf6WwyawPKeBwle692coO7ILZqSO+UJe9899aDn9sMdeOHA==
terser@^5.0.0: terser@^5.0.0:
version "5.14.2" version "5.14.2"