mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-15 02:11:05 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(DataTable): handle null/undefined values when sorting (#846)

Browse source
This commit is contained in:
Paweł Malinowski 2021-10-11 19:11:59 +02:00 • committed by GitHub
commit d3eb146fb5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/DataTable/DataTable.svelte
View file

@ -194,6 +194,10 @@
if (typeof itemA === "number" && typeof itemB === "number") if (typeof itemA === "number" && typeof itemB === "number")
return itemA - itemB; return itemA - itemB;
if ([itemA, itemB].every((item) => !item && item !== 0)) return 0;
if (!itemA && itemA !== 0) return ascending ? 1 : -1;
if (!itemB && itemB !== 0) return ascending ? -1 : 1;
return itemA return itemA
.toString() .toString()
.localeCompare(itemB.toString(), "en", { numeric: true }); .localeCompare(itemB.toString(), "en", { numeric: true });