mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-15 18:31:06 +00:00
Code Issues Projects Releases Packages Wiki Activity

Modify click events to prevent navigation. (#946)

Browse source 
Without preventDefault the link will navigate the page instead of opening the dropdown when the tabs are in the compact mode.
Because the parent element also toggles on click, there is an additional stopPropagation to not toggle twice which in a no-op.
This commit is contained in:
brunnerh 2021-12-28 21:59:26 +01:00 • committed by GitHub
commit d5a6b5873b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/Tabs/Tabs.svelte
View file

@ -130,8 +130,8 @@
tabindex="-1" tabindex="-1"
class:bx--tabs-trigger-text="{true}" class:bx--tabs-trigger-text="{true}"
href="{triggerHref}" href="{triggerHref}"
on:click on:click|preventDefault
on:click="{() => { on:click|preventDefault|stopPropagation="{() => {
dropdownHidden = !dropdownHidden; dropdownHidden = !dropdownHidden;
}}" }}"
> >