mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-15 10:21:05 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(loading)!: remove redundant description label (#1783)

Browse source 
Fixes #1670
This commit is contained in:
Eric Liu 2023-07-23 14:07:55 -07:00 • committed by GitHub
commit d6804b44fe
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 25 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/Loading/Loading.svelte
View file

@ -8,11 +8,8 @@
/** Set to `false` to disable the overlay */
export let withOverlay = true;
/** Specify the label description */
export let description = "Active loading indicator";
/** Set an id for the label element */
export let id = "ccs-" + Math.random().toString(36);
/** Specify the description to describe the loading state */
export let description = "loading";
$: spinnerRadius = small ? "42" : "44";
</script>
@ -25,14 +22,11 @@
>
<div
aria-atomic="true"
aria-labelledby="{id}"
aria-live="{active ? 'assertive' : 'off'}"
class:bx--loading="{true}"
class:bx--loading--small="{small}"
class:bx--loading--stop="{!active}"
>
<!-- svelte-ignore a11y-label-has-associated-control -->
<label class:bx--visually-hidden="{true}" id="{id}">{description}</label>
<svg class:bx--loading__svg="{true}" viewBox="0 0 100 100">
<title>{description}</title>
{#if small}
@ -53,15 +47,12 @@
{:else}
<div
aria-atomic="true"
aria-labelledby="{id}"
aria-live="{active ? 'assertive' : 'off'}"
class:bx--loading="{true}"
class:bx--loading--small="{small}"
class:bx--loading--stop="{!active}"
{...$$restProps}
>
<!-- svelte-ignore a11y-label-has-associated-control -->
<label class:bx--visually-hidden="{true}" id="{id}">{description}</label>
<svg class:bx--loading__svg="{true}" viewBox="0 0 100 100">
<title>{description}</title>
{#if small}