mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-15 02:11:05 +00:00
Code Issues Projects Releases Packages Wiki Activity

Refactor onDestroy to use onMount return function (#914)

Browse source 
* refactor(select-item): replace onDestroy with onMount return function

* refactor(date-picker): replace onDestroy with onMount return function

* refactor(switch): replace onDestroy with onMount return function

* refactor(composed-modal): replace onDestroy with onMount return function
This commit is contained in:
Eric Liu 2021-11-17 13:20:26 -08:00 • committed by GitHub
commit dfd53ce09b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 23 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/DatePicker/DatePicker.svelte
View file

@ -70,7 +70,7 @@
createEventDispatcher,
setContext,
afterUpdate,
onDestroy,
onMount,
} from "svelte";
import { writable, derived } from "svelte/store";
import { createCalendar } from "./createCalendar";
@ -175,6 +175,15 @@
});
}
onMount(() => {
return () => {
if (calendar) {
calendar.destroy();
calendar = null;
}
};
});
afterUpdate(() => {
if (calendar) {
if ($range) {
@ -188,13 +197,6 @@
}
});
onDestroy(() => {
if (calendar) {
calendar.destroy();
calendar = null;
}
});
$: inputValue.set(value);
$: value = $inputValue;
$: inputValueFrom.set(valueFrom);