mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-15 18:31:06 +00:00
Code Issues Projects Releases Packages Wiki Activity

refactor(modal): set alert dialog attributes in markup (#1333)

Browse source
This commit is contained in:
metonym 2022-06-02 18:41:18 -07:00 • committed by GitHub
commit e62bea38aa
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/Modal/Modal.svelte
View file

@ -139,16 +139,6 @@
$: ariaLabel = $: ariaLabel =
modalLabel || $$props["aria-label"] || modalAriaLabel || modalHeading; modalLabel || $$props["aria-label"] || modalAriaLabel || modalHeading;
let alertDialogProps = {};
$: if (alert) {
if (passiveModal) {
alertDialogProps.role = "alert";
}
if (!passiveModal) {
alertDialogProps.role = "alertdialog";
alertDialogProps["aria-describedby"] = modalBodyId;
}
}
$: if (open) { $: if (open) {
addModalId(id); addModalId(id);
} else { } else {
@ -214,9 +204,9 @@
> >
<div <div
bind:this="{innerModal}" bind:this="{innerModal}"
role="dialog"
tabindex="-1" tabindex="-1"
{...alertDialogProps} role="{alert ? (passiveModal ? 'alert' : 'alertdialog') : 'dialog'}"
aria-describedby="{alert && !passiveModal ? modalBodyId : undefined}"
aria-modal="true" aria-modal="true"
aria-label="{ariaLabel}" aria-label="{ariaLabel}"
class:bx--modal-container="{true}" class:bx--modal-container="{true}"