mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-15 10:21:05 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(data-table): prefix internal ID for radio button, checkbox (#2082)

Browse source 
Fixes #2081
This commit is contained in:
Eric Liu 2025-01-19 16:22:23 -08:00 • committed by GitHub
commit eb1567ac1b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 28 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/DataTable/DataTable.svelte
View file

@ -170,6 +170,10 @@
const batchSelectedIds = writable(false);
const tableRows = writable(rows);
// Internal ID prefix for radio buttons, checkboxes, etc.
// since there may be multiple `DataTable` instances that have overlapping row ids.
const id = "ccs-" + Math.random().toString(36);
// Store a copy of the original rows for filter restoration.
$: originalRows = [...rows];
@ -499,7 +503,7 @@
{#if !nonSelectableRowIds.includes(row.id)}
{#if radio}
<RadioButton
name="select-row-{row.id}"
name="{id}-{row.id}"
checked={selectedRowIds.includes(row.id)}
on:change={() => {
selectedRowIds = [row.id];
@ -508,7 +512,7 @@
/>
{:else}
<InlineCheckbox
name="select-row-{row.id}"
name="{id}-{row.id}"
checked={selectedRowIds.includes(row.id)}
on:change={() => {
if (selectedRowIds.includes(row.id)) {