From eb8ece3073db4345542aa7b566b471bc58b3e90e Mon Sep 17 00:00:00 2001 From: metonym Date: Mon, 10 Jan 2022 11:47:35 -1000 Subject: [PATCH] fix: resolve a11y violations Fixes #988 --- src/Dropdown/Dropdown.svelte | 1 - src/UIShell/GlobalHeader/Header.svelte | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Dropdown/Dropdown.svelte b/src/Dropdown/Dropdown.svelte index 0b503dd6..d6732b74 100644 --- a/src/Dropdown/Dropdown.svelte +++ b/src/Dropdown/Dropdown.svelte @@ -198,7 +198,6 @@ bind:this="{ref}" class:bx--list-box__field="{true}" tabindex="0" - role="button" aria-expanded="{open}" on:keydown="{(e) => { const { key } = e; diff --git a/src/UIShell/GlobalHeader/Header.svelte b/src/UIShell/GlobalHeader/Header.svelte index ea8f203e..878326cd 100644 --- a/src/UIShell/GlobalHeader/Header.svelte +++ b/src/UIShell/GlobalHeader/Header.svelte @@ -78,7 +78,7 @@ -
+
{#if ($shouldRenderHamburgerMenu && winWidth < expansionBreakpoint) || persistentHamburgerMenu}