From f19589ac542c2246944d6ef88f39fdda76521fb9 Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Tue, 31 Dec 2019 07:58:21 -0800 Subject: [PATCH 1/5] fix(combo-box): apply filter when open --- src/components/ComboBox/ComboBox.svelte | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/components/ComboBox/ComboBox.svelte b/src/components/ComboBox/ComboBox.svelte index 0c7b6e1a..aec48f2a 100644 --- a/src/components/ComboBox/ComboBox.svelte +++ b/src/components/ComboBox/ComboBox.svelte @@ -30,6 +30,7 @@ ListBoxSelection } from '../ListBox'; + let selectedId = undefined; let inputRef = undefined; let inputValue = undefined; let highlightedIndex = -1; @@ -49,6 +50,7 @@ afterUpdate(() => { if (open) { inputRef.focus(); + filteredItems = items.filter(item => shouldFilterItem(item, value)); } else { highlightedIndex = -1; inputValue = selectedItem ? selectedItem.text : ''; @@ -165,10 +167,11 @@ {#each filteredItems as item, i (item.id || i)} { - selectedIndex = i; + selectedId = item.id; + selectedIndex = items.map(({ id }) => id).indexOf(filteredItems[i].id); open = false; }} on:mouseenter={() => { From 138f672ae4e5f108d9b1c5642c5c3585a7f11538 Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Tue, 31 Dec 2019 07:58:47 -0800 Subject: [PATCH 2/5] feat(checkbox): export name prop --- src/components/Checkbox/Checkbox.svelte | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/components/Checkbox/Checkbox.svelte b/src/components/Checkbox/Checkbox.svelte index f1200a6a..05f4f5d3 100644 --- a/src/components/Checkbox/Checkbox.svelte +++ b/src/components/Checkbox/Checkbox.svelte @@ -6,6 +6,7 @@ export let disabled = false; export let id = Math.random(); export let labelText = ''; + export let name = ''; export let hideLabel = false; export let title = ''; export let style = undefined; @@ -37,6 +38,7 @@ {indeterminate} {disabled} {checked} + {name} {id} />