From 3f3093d1566d38339fa5973f812aaa57e9e44962 Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Thu, 15 Oct 2020 17:15:27 -0700 Subject: [PATCH 1/9] docs: set min height on .bx--content --- docs/src/pages/_layout.svelte | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/src/pages/_layout.svelte b/docs/src/pages/_layout.svelte index 4aa38814..854942f8 100644 --- a/docs/src/pages/_layout.svelte +++ b/docs/src/pages/_layout.svelte @@ -112,6 +112,7 @@ main.bx--content { background: none; + min-height: calc(100vh - 3rem - 3rem); } @media (max-width: 1056px) { From b0dbcb8f0686b2e901ddee7f7e3597e2f66b0095 Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Thu, 15 Oct 2020 17:21:46 -0700 Subject: [PATCH 2/9] docs: use AspectRatio from library --- docs/src/components/AspectRatio.svelte | 16 ---------------- docs/src/components/TileCard.svelte | 3 +-- 2 files changed, 1 insertion(+), 18 deletions(-) delete mode 100644 docs/src/components/AspectRatio.svelte diff --git a/docs/src/components/AspectRatio.svelte b/docs/src/components/AspectRatio.svelte deleted file mode 100644 index 592ed2f4..00000000 --- a/docs/src/components/AspectRatio.svelte +++ /dev/null @@ -1,16 +0,0 @@ - - -
-
- -
-
diff --git a/docs/src/components/TileCard.svelte b/docs/src/components/TileCard.svelte index 5cf099ef..eadaae87 100644 --- a/docs/src/components/TileCard.svelte +++ b/docs/src/components/TileCard.svelte @@ -5,8 +5,7 @@ export let borderRight = false; export let borderBottom = false; - import { ClickableTile, Tile } from "carbon-components-svelte"; - import AspectRatio from "./AspectRatio.svelte"; + import { AspectRatio, ClickableTile, Tile } from "carbon-components-svelte"; import LogoGithub32 from "carbon-icons-svelte/lib/LogoGithub32"; import Launch20 from "carbon-icons-svelte/lib/Launch20"; From a02be58ac82e1a2ea0e24ca46037c242513f3495 Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Thu, 15 Oct 2020 17:27:06 -0700 Subject: [PATCH 3/9] docs(framed): add min height, padding to framed components --- docs/src/pages/framed/_reset.svelte | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/src/pages/framed/_reset.svelte b/docs/src/pages/framed/_reset.svelte index fa10613a..8366e4ea 100644 --- a/docs/src/pages/framed/_reset.svelte +++ b/docs/src/pages/framed/_reset.svelte @@ -4,4 +4,12 @@ $: document.documentElement.setAttribute("theme", currentTheme); + + From 7345cc1b839576ac827fbd7c9efa5903b9ad4842 Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Thu, 15 Oct 2020 17:27:27 -0700 Subject: [PATCH 4/9] docs(preview): move inline loader above preview --- docs/src/components/Preview.svelte | 25 +++++++------------------ 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/docs/src/components/Preview.svelte b/docs/src/components/Preview.svelte index acbef287..c412b82d 100644 --- a/docs/src/components/Preview.svelte +++ b/docs/src/components/Preview.svelte @@ -107,11 +107,12 @@ } .preview-viewer.framed { - min-height: 22rem; + min-height: 20rem; } .framed-header { display: flex; + align-items: center; } iframe { @@ -121,23 +122,16 @@ width: 100%; height: 100%; } - - .loader { - position: absolute; - top: 0; - left: 0; - width: 100%; - height: 100%; - display: flex; - align-items: center; - justify-content: center; - }
{#if framed}
-
+
+ {#if framed && !success} + + {/if} +