mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-14 18:01:06 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(toolbar-search): re-filter rows if DataTable rows change (#2154)

Browse source 
Fixes #2143

Make `ToolbarSearch` filtering reactive to `DataTable` rows.

Previously, `ToolbarSearch` did not update when `DataTable` rows
changed. Now it subscribes to the context rows and re-runs
`filterRows` in `afterUpdate` to prevent infinite loops.
This commit is contained in:
Eric Liu 2025-04-19 13:33:07 -07:00 • committed by GitHub
commit f09c2e2c31
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 27 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
tests/DataTable/DataTableSearch.test.ts
View file

@ -182,8 +182,7 @@ describe("DataTableSearch", () => {
});
});
// TODO: fix reactivity
it.skip("re-filters rows when toggled", async () => {
it("re-filters rows when toggled", async () => {
render(DataTableSearch);
allRowsRendered();