From e1fbd562313a2295eb03cf7a59cf745ff9fe43cd Mon Sep 17 00:00:00 2001 From: josefaidt Date: Fri, 18 Sep 2020 15:22:39 -0500 Subject: [PATCH 1/2] fix(TimePickerSelect): deprecate hideLabel to match spec --- src/TimePicker/TimePicker.stories.js | 1 - src/TimePicker/TimePickerSelect.svelte | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/TimePicker/TimePicker.stories.js b/src/TimePicker/TimePicker.stories.js index 4f99ee7b..63412594 100644 --- a/src/TimePicker/TimePicker.stories.js +++ b/src/TimePicker/TimePicker.stories.js @@ -36,7 +36,6 @@ export const Default = () => ({ }, select: { disabled: boolean("Disabled (disabled in )", false), - hideLabel: boolean("No label (hideLabel in )", true), labelText: text( "Label text (labelText in )", "Please select" diff --git a/src/TimePicker/TimePickerSelect.svelte b/src/TimePicker/TimePickerSelect.svelte index 0cbb36fd..03fddfb9 100644 --- a/src/TimePicker/TimePickerSelect.svelte +++ b/src/TimePicker/TimePickerSelect.svelte @@ -24,6 +24,7 @@ export let labelText = ""; /** + * @deprecated The `hideLabel` prop for `TimePickerSelect` is no longer needed and has been deprecated. It will be removed in the next major release. * Set to `true` to visually hide the label text * @type {boolean} [hideLabel=false] */ @@ -72,6 +73,7 @@ for="{id}" class:bx--label="{true}" class:bx--visually-hidden="{hideLabel}"> + {labelText} {/if} From d095fda8aa8494d2fccdecb52f9e06ad1d100bbe Mon Sep 17 00:00:00 2001 From: josefaidt Date: Fri, 18 Sep 2020 15:38:46 -0500 Subject: [PATCH 2/2] hotfix(TimePickerSelect): hideLabel should be true --- src/TimePicker/TimePickerSelect.svelte | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/TimePicker/TimePickerSelect.svelte b/src/TimePicker/TimePickerSelect.svelte index 03fddfb9..bb926625 100644 --- a/src/TimePicker/TimePickerSelect.svelte +++ b/src/TimePicker/TimePickerSelect.svelte @@ -25,10 +25,10 @@ /** * @deprecated The `hideLabel` prop for `TimePickerSelect` is no longer needed and has been deprecated. It will be removed in the next major release. - * Set to `true` to visually hide the label text - * @type {boolean} [hideLabel=false] + * Set to `false` to show the label text + * @type {boolean} [hideLabel=true] */ - export let hideLabel = false; + export let hideLabel = true; /** * Set an id for the select element