mirror of
https://github.com/carbon-design-system/carbon-components-svelte.git
synced 2025-09-15 10:21:05 +00:00
fix(ToolTip): better toggling logic (#885)
* fix(ToolTip): better toggling logic * fix(ToolTip): remove redundant click handler * fix(ToolTip): ensure at most one ToolTip is open at the same time - a click event closes the tooltip if the target is not the tooltip or the tooltip icon. - the event is registered in the capture phase and a `setTimeout` is used to deal with edge cases in which a button is used to toggle the tooltip on or off.
This commit is contained in:
parent
0e460cdd91
commit
f32f8fb9dc
1 changed files with 21 additions and 7 deletions
|
@ -89,10 +89,19 @@
|
|||
}
|
||||
}
|
||||
|
||||
function openMenu() {
|
||||
function onFocus() {
|
||||
open = true;
|
||||
}
|
||||
|
||||
function onMousedown() {
|
||||
// determine the desired state before the focus event triggers.
|
||||
const shouldClose = open;
|
||||
// ensure changes are scheduled at the end, i.e. after the possible focus event.
|
||||
setTimeout(() => {
|
||||
open = shouldClose ? false : true;
|
||||
});
|
||||
}
|
||||
|
||||
afterUpdate(() => {
|
||||
if (open) {
|
||||
const button = ref.getBoundingClientRect();
|
||||
|
@ -173,8 +182,13 @@
|
|||
ref.focus();
|
||||
}
|
||||
}
|
||||
|
||||
open = false;
|
||||
}
|
||||
}}"
|
||||
on:click|capture="{({ target }) => {
|
||||
if (open && !ref.contains(target) && !refTooltip.contains(target)) {
|
||||
setTimeout(() => {
|
||||
open = false;
|
||||
});
|
||||
}
|
||||
}}"
|
||||
/>
|
||||
|
@ -190,8 +204,8 @@
|
|||
bind:this="{refIcon}"
|
||||
{...buttonProps}
|
||||
aria-describedby="{tooltipId}"
|
||||
on:click|preventDefault|stopPropagation="{openMenu}"
|
||||
on:focus="{openMenu}"
|
||||
on:mousedown="{onMousedown}"
|
||||
on:focus="{onFocus}"
|
||||
on:blur="{onBlur}"
|
||||
on:keydown="{onKeydown}"
|
||||
>
|
||||
|
@ -205,8 +219,8 @@
|
|||
bind:this="{ref}"
|
||||
{...buttonProps}
|
||||
aria-describedby="{tooltipId}"
|
||||
on:click|preventDefault|stopPropagation="{openMenu}"
|
||||
on:focus="{openMenu}"
|
||||
on:mousedown="{onMousedown}"
|
||||
on:focus="{onFocus}"
|
||||
on:blur="{onBlur}"
|
||||
on:keydown="{onKeydown}"
|
||||
>
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue