From a1377f07de0af0174c25e1b2f51cb263aa29ab8b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Istv=C3=A1n=20Pat=C3=B3?= Date: Tue, 28 Dec 2021 21:59:20 +0100 Subject: [PATCH 01/19] fix(textinput): displaying empty input value if value is undefined or null (#936) #935 --- src/TextArea/TextArea.svelte | 2 +- src/TextInput/PasswordInput.svelte | 2 +- src/TextInput/TextInput.svelte | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/TextArea/TextArea.svelte b/src/TextArea/TextArea.svelte index 5d43749b..8e14d164 100644 --- a/src/TextArea/TextArea.svelte +++ b/src/TextArea/TextArea.svelte @@ -85,7 +85,7 @@ name="{name}" cols="{cols}" rows="{rows}" - value="{value}" + value="{value ?? ''}" placeholder="{placeholder}" class:bx--text-area="{true}" class:bx--text-area--light="{light}" diff --git a/src/TextInput/PasswordInput.svelte b/src/TextInput/PasswordInput.svelte index 53f22dd0..25064f66 100644 --- a/src/TextInput/PasswordInput.svelte +++ b/src/TextInput/PasswordInput.svelte @@ -170,7 +170,7 @@ name="{name}" placeholder="{placeholder}" type="{type}" - value="{value}" + value="{value ?? ''}" disabled="{disabled}" class:bx--text-input="{true}" class:bx--password-input="{true}" diff --git a/src/TextInput/TextInput.svelte b/src/TextInput/TextInput.svelte index a9399367..b353b6b4 100644 --- a/src/TextInput/TextInput.svelte +++ b/src/TextInput/TextInput.svelte @@ -163,7 +163,7 @@ name="{name}" placeholder="{placeholder}" type="{type}" - value="{value}" + value="{value ?? ''}" required="{required}" readonly="{readonly}" class:bx--text-input="{true}" From d5a6b5873bc2f016200b635d50b188e546e96822 Mon Sep 17 00:00:00 2001 From: brunnerh Date: Tue, 28 Dec 2021 21:59:26 +0100 Subject: [PATCH 02/19] Modify click events to prevent navigation. (#946) Without preventDefault the link will navigate the page instead of opening the dropdown when the tabs are in the compact mode. Because the parent element also toggles on click, there is an additional stopPropagation to not toggle twice which in a no-op. --- src/Tabs/Tabs.svelte | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Tabs/Tabs.svelte b/src/Tabs/Tabs.svelte index b844066e..b7b885b0 100644 --- a/src/Tabs/Tabs.svelte +++ b/src/Tabs/Tabs.svelte @@ -130,8 +130,8 @@ tabindex="-1" class:bx--tabs-trigger-text="{true}" href="{triggerHref}" - on:click - on:click="{() => { + on:click|preventDefault + on:click|preventDefault|stopPropagation="{() => { dropdownHidden = !dropdownHidden; }}" > From a32bcbccd7312136629ef77c9cd9d988a8730afc Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Tue, 28 Dec 2021 12:59:33 -0800 Subject: [PATCH 03/19] fix(label-text): correctly render "labelText" slots (#949) Fixes #944 --- src/DatePicker/DatePickerInput.svelte | 2 +- src/TextArea/TextArea.svelte | 2 +- src/TimePicker/TimePicker.svelte | 2 +- src/TimePicker/TimePickerSelect.svelte | 2 +- src/Toggle/ToggleSkeleton.svelte | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/DatePicker/DatePickerInput.svelte b/src/DatePicker/DatePickerInput.svelte index 54d000a6..e39483e5 100644 --- a/src/DatePicker/DatePickerInput.svelte +++ b/src/DatePicker/DatePickerInput.svelte @@ -82,7 +82,7 @@ class:bx--date-picker-container="{true}" class:bx--date-picker--nolabel="{!labelText}" > - {#if labelText} + {#if labelText || $$slots.labelText}