chore: address review comments

This commit is contained in:
Enrico Sacchetti 2023-01-14 19:34:47 -05:00 committed by GitHub
commit fc270618ad
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 2 deletions

View file

@ -159,7 +159,11 @@ git merge upstream/master
After you've pushed your changes to remote, submit your PR. Make sure you are comparing `<YOUR_USER_ID>/feature` to `origin/master`. After you've pushed your changes to remote, submit your PR. Make sure you are comparing `<YOUR_USER_ID>/feature` to `origin/master`.
## Release ## Maintainer guide
The following items only apply to project maintainers.
### Release
Locally, while on `master` and the branch is clean, run `yarn release`. This command will: Locally, while on `master` and the branch is clean, run `yarn release`. This command will:
@ -167,7 +171,7 @@ Locally, while on `master` and the branch is clean, run `yarn release`. This com
- Bump package.json version - Bump package.json version
- Add notes to Changelog - Add notes to Changelog
Afterwards, perform the following manually: This command will not create a commit nor tag. Afterwards, perform the following manually:
```sh ```sh
# 1. Stage prepared files for a commit # 1. Stage prepared files for a commit

View file

@ -71,6 +71,7 @@
"css" "css"
], ],
"contributors": [ "contributors": [
"Josef Aidt (https://github.com/josefaidt)",
"Eric Liu (https://github.com/metonym)", "Eric Liu (https://github.com/metonym)",
"Enrico Sacchetti (https://github.com/theetrain)" "Enrico Sacchetti (https://github.com/theetrain)"
] ]