From fed83f8bf4b23bd530b810370d882e8fbe069211 Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Wed, 3 Feb 2021 05:56:51 -0800 Subject: [PATCH] fix(tabs): forward click event to Tab --- COMPONENT_INDEX.md | 1 + docs/src/COMPONENT_API.json | 1 + src/Tabs/Tab.svelte | 1 + types/Tabs/Tab.d.ts | 1 + 4 files changed, 4 insertions(+) diff --git a/COMPONENT_INDEX.md b/COMPONENT_INDEX.md index 85875a50..dcf27241 100644 --- a/COMPONENT_INDEX.md +++ b/COMPONENT_INDEX.md @@ -3401,6 +3401,7 @@ None. | Event name | Type | Detail | | :--------- | :-------- | :----- | +| click | forwarded | -- | | mouseover | forwarded | -- | | mouseenter | forwarded | -- | | mouseleave | forwarded | -- | diff --git a/docs/src/COMPONENT_API.json b/docs/src/COMPONENT_API.json index f04a99cf..3be502ac 100644 --- a/docs/src/COMPONENT_API.json +++ b/docs/src/COMPONENT_API.json @@ -7708,6 +7708,7 @@ } ], "events": [ + { "type": "forwarded", "name": "click", "element": "li" }, { "type": "forwarded", "name": "mouseover", "element": "li" }, { "type": "forwarded", "name": "mouseenter", "element": "li" }, { "type": "forwarded", "name": "mouseleave", "element": "li" } diff --git a/src/Tabs/Tab.svelte b/src/Tabs/Tab.svelte index e2492981..a2aa5572 100644 --- a/src/Tabs/Tab.svelte +++ b/src/Tabs/Tab.svelte @@ -39,6 +39,7 @@ class:bx--tabs__nav-item--disabled="{disabled}" class:bx--tabs__nav-item--selected="{selected}" {...$$restProps} + on:click|preventDefault on:click|preventDefault="{() => { if (!disabled) { update(id); diff --git a/types/Tabs/Tab.d.ts b/types/Tabs/Tab.d.ts index c0fd922f..28d20dbe 100644 --- a/types/Tabs/Tab.d.ts +++ b/types/Tabs/Tab.d.ts @@ -45,6 +45,7 @@ export default class Tab { default: {}; }; + $on(eventname: "click", cb: (event: WindowEventMap["click"]) => void): () => void; $on(eventname: "mouseover", cb: (event: WindowEventMap["mouseover"]) => void): () => void; $on(eventname: "mouseenter", cb: (event: WindowEventMap["mouseenter"]) => void): () => void; $on(eventname: "mouseleave", cb: (event: WindowEventMap["mouseleave"]) => void): () => void;