Commit graph

974 commits

Author SHA1 Message Date
metonym
6a13ca1c0d
fix(file-uploader): correctly fire add/remove events (#1121)
Fixes #1119
2022-02-21 09:18:29 -08:00
metonym
25d28a9c4d
fix(file-uploader): FileUploader files should not be keyed (#1118)
Fixes #1115
2022-02-21 08:36:58 -08:00
metonym
7602731b0b
fix(file-uploader): FileUploader change detail should be File[] instead of FileList (#1117)
Fixes #1112
2022-02-21 08:34:03 -08:00
metonym
dce0309bab
fix(data-table): pass header key to TableHeader (#1114)
The id is needed to update the sort icon direction accordingly.

Fixes #1113
2022-02-21 08:33:41 -08:00
metonym
df4ed9d75a
fix(types): use @component comments for deprecation notices (#1111)
The Svelte Language Server allows component-level comments through `<!-- @component ... -->` syntax.

Deprecation notices for components should be moved from the script block to the markup template.
2022-02-19 18:50:25 -08:00
metonym
7c0086d00c
fix: slottable labelText should correctly render (#1110) 2022-02-19 18:24:26 -08:00
Malte Heinzelmann
33c1543bd0
fix(password-input): do not render label if labelText is not provided (#1108) 2022-02-19 18:01:49 -08:00
metonym
6dc17dd8b3
fix(structured-list): override overfow-y to be visible (#1107)
Fixes #1106
2022-02-18 15:54:23 -08:00
metonym
73b105660c
fix(multi-select): ListBoxField should not prevent default keyboard behavior (#1101)
Fixes #938
2022-02-18 15:54:00 -08:00
metonym
1ad2ca404a
fix(content-switcher): Switch should have type="button" (#1104)
Fixes #1103
2022-02-18 06:12:28 -08:00
metonym
c32df50689
fix(tooltip): aria-label should use iconDescription if triggerText is falsy (#1095) 2022-02-12 15:43:58 -08:00
metonym
c7de897b89
fix(overflow-menu): keyboard navigation should skip disabled items (#1096) 2022-02-12 15:43:45 -08:00
metonym
16790daaa9
fix(ui-shell): use semantic hr in HeaderPanelDivider to render dividers (#1093) 2022-02-12 08:07:21 -08:00
brunnerh
05e4c282b0
fix(button): not set aria-pressed on link buttons (#1091) 2022-02-12 06:47:53 -08:00
metonym
2f556cdda3
fix(code-snippet): remove whitespace from pre tag (#1088)
Svelte v3.46.4 preserves whitespace inside `pre` tags by default; this removes whitespace from inside the `pre` tag in `CodeSnippet`.
2022-02-11 16:56:46 -08:00
metonym
3b70a35df6
feat(data-table): pass row index, cell index to "cell" slot (#1086) 2022-02-11 07:13:55 -08:00
metonym
34affd851a
fix(data-table): batch selection checkbox should be reactive (#1085) 2022-02-10 19:51:26 -08:00
metonym
a3c329a2e8
fix(ui-shell): prevent default behavior when pressing Space (#1084) 2022-02-10 19:27:59 -08:00
metonym
2148e1c7b6
feat(multi-select): add itemToProp to customize name, title, labelText values passed to input (#1074)
Currently, the input `name` for each item uses the same value as `itemToString(item)`.

This adds an `itemToInput` prop to allow the consumer to customize the name/title/labelText values passed to the `Checkbox` input.

The name attribute now defaults to use the `item.id` instead of `item.text`.
2022-02-10 08:32:24 -08:00
metonym
63f52b4683
fix(multi-select): non-filterable MultiSelect should dispatch a blur event (#1080)
The non-filterable `MultiSelect` is missing a `blur` event.

Implementation-wise, we have to dispatch it and include the event as the `detail`. Otherwise, the filterable variant will dispatch "blur" twice because it has both a button and input.

The filterable `MultiSelect` continues to forward the blur event to the input.
2022-02-10 08:27:09 -08:00
metonym
1939e4328d
fix(ui-shell): fix HeaderNavMenu accessibility, undefined context (#1079)
Fixes:

* hotfix: remove toggle accessor from HeaderNavMenu

* hotfix(ui-shell): HeaderNavMenu context is possibly undefined

* fix: apply a11y navigation menubar attributes
2022-02-10 08:11:56 -08:00
metonym
5103e13321
feat(css): upgrade carbon-components to v10.52.0 (#1078)
Fixes:

- move `FileUploaderDropContainer` input outside of label to fix a11y error
- prevent inadvertent text selection when clicking through flatpickr months
2022-02-10 06:47:36 -08:00
metonym
18eb1e2649
fix(ui-shell): HeaderNavMenu should close when pressing Enter (#1073)
Fixes:

- pressing "Enter" on a `HeaderNavMenuItem` should close the menu
- tab blurring the last item in an open menu should close the menu
- remove "role" to fix a11y warning
2022-02-10 06:46:11 -08:00
metonym
20e61724c1
feat(tooltip-definition): export open prop, dispatch open/close events (#1057) 2022-02-09 20:00:38 -08:00
metonym
8b39ccae89
fix(multi-select): MultiSelect should correctly lose focus (#1077)
Currently, opening a MultiSelect and then clicking an interactive target will cause the MultiSelect to retain focus. This removes the logic that interferes with native blurring behavior.
2022-02-09 19:53:07 -08:00
metonym
989e0f4c65
breaking(text-input): use native bind:value, dispatch instead of forward change, input events (#1065)
Use the native `bind:value` to fix two-way reactivity. As a result, "type" is read through `$$restProps` because it cannot be dynamic when using `bind:value`.

Extend value type to include `null` for the "number" type. This is similar to how `NumberInput` works; `null` represents "no value."
2022-02-09 19:52:10 -08:00
metonym
30a5f2c201
fix(multi-select): resolve a11y violations (#1072)
- role="listbox" children require the role="option" attribute
- add a "aria-multiselectable" attribute to the listbox menu
- move "aria-label" attribute from listbox to listbox menu
- listbox field should not have a "combobox" role when expanded (the non-filterable variant serves as a button)
2022-02-09 19:49:30 -08:00
metonym
a5f5550aa0
fix(data-table): headers should be reactive (#1075)
If `headers` is dynamically updated, clicking a sortable table header will sort the incorrect column. Instead of randomly generating an id and keeping track of it through context, we can simply use the required key in `headers` as the id.
2022-02-09 19:48:20 -08:00
metonym
504cf09dc8
fix(tooltip): type Tooltip open, close events (#1058) 2022-02-01 07:20:43 -08:00
metonym
5358cf66ea
fix(tooltip-definition): button should have type "button" (#1056)
Fixes #1055
2022-02-01 07:05:20 -08:00
brunnerh
099efedef1
breaking(number-input): align change, input events with native input behavior (#1053)
* Closes #1052

* Closes #1050
2022-01-30 09:01:51 -08:00
Gregor Wassmann
a8039a4d1e
feat(modal): support primaryButtonIcon prop (#1047) 2022-01-29 09:35:08 -08:00
metonym
402de56029
fix(number-input): value 0 should not be converted to null (#1046) 2022-01-27 08:00:32 -08:00
metonym
9e915cf90a
breaking(number-input): type value as null | number (#1044)
Fixes #1039
2022-01-27 06:57:32 -08:00
metonym
3018c2b207
fix(text-area): export readonly prop (#1043)
Fixes #1009
2022-01-26 19:19:49 -08:00
metonym
048ebc7b81
fix(checkbox): fix two-way binding (#1042)
Fixes #967
2022-01-26 19:04:32 -08:00
brunnerh
25ce57fd5a
Add required prop to RadioButton. (#1035)
Fixes #1034.
2022-01-22 09:05:41 -08:00
Eric Liu
493568f08d
feat(number-input): forward focus, blur events to input (#1033) 2022-01-22 08:58:59 -08:00
Eric Liu
222d5a90e4
fix(number-input): empty input should not be coerced to 0 (#1032)
Fixes #1031
2022-01-22 08:58:48 -08:00
Eric Liu
4d51250173
Align 10.51 (#1021)
* chore(deps-dev): upgrade carbon-components to v10.51.0

* fix(slider): input should also be labelled

* refactor(date-picker): remove hotfix logic to prevent disabled icon from being clickable

Ref: https://github.com/carbon-design-system/carbon-components-svelte/pull/860

* feat(progress-step): update icons for current, incomplete steps
2022-01-22 08:02:24 -08:00
brunnerh
201e03757b
Add required prop to Checkbox. (#1030)
Fixes #1029.
2022-01-22 07:43:53 -08:00
Eric Liu
1f7b5560a8
Type id as any in ComboBox, Dropdown, MultiSelect (#1019)
Loosen the prop type for `id`, `selectedId` to be `any` instead of a `string`.
2022-01-20 18:50:36 -08:00
kwieszalka-maystreet
5da83ec869
feat(data-table): support paginated data table (#880)
Closes #702
2022-01-19 07:51:42 -08:00
István Pató
cfa036d7a6
fix(dropdown): prevent icon from being clickable in disabled state (#1017)
* fix(Dropdown): list icon was clickable in disabled state

* fix(Dropdown): the ListBox element was selectable in disabled state if extended Dropdown
2022-01-18 06:38:21 -08:00
Koichi Kiyokawa
cde8a79fa8
feat(ComboBox): selectedIndex -> selectedId (#1016)
* feat(breaking): selectedIndex -> selectedId in ComboBox

* docs: update ComboBox
2022-01-18 06:37:55 -08:00
Koichi Kiyokawa
e11a893bee
feat(Dropdown): selectedIndex -> selectedId (#1004)
* feat(breaking): selectedIndex -> selectedId in Dropdown

* feat: omit `selectedIndex` from the `select` event
2022-01-18 06:37:32 -08:00
Eric Liu
b13bb8e09f
fix(tooltip): pressing "Escape" should break out of trap focus (#1015)
Fixes #924
2022-01-17 13:40:10 -08:00
Eric Liu
a60bc73fea
fix(combo-box): name should be passed to input (#1014)
Fixes #797
2022-01-17 13:07:42 -08:00
Alexis Reigel
9b32fe90f5
Emit Checkbox change event after modifying internal state (#1013)
The checkbox's internal state doesn't match the visual checked /
unchecked state. The behaviour is visible when using 1-way binding on
the checkbox and using the on:change event. The internal state is always
the opposite of the visual state.
2022-01-17 12:50:08 -08:00
Eric Liu
653a601f9b
Revert "Refactor prop types to omit redundant null for null | HTMLElement types" (#1008)
#996
2022-01-14 11:29:37 -10:00