From 14f23962c31df4d51620c616d38ba5810bc22a57 Mon Sep 17 00:00:00 2001 From: Gregor Wassmann Date: Fri, 24 Mar 2023 23:48:00 +0100 Subject: [PATCH 001/562] chore: run `yarn lint` (#1701) --- CHANGELOG.md | 14 +++++--------- README.md | 2 +- src/NumberInput/NumberInput.svelte | 4 ++-- 3 files changed, 8 insertions(+), 12 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c553db25..58c0dba2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,32 +4,28 @@ All notable changes to this project will be documented in this file. See [standa ### [0.73.4](https://github.com/carbon-design-system/carbon-components-svelte/compare/v0.73.3...v0.73.4) (2023-03-21) - ### Bug Fixes -* **selectable-tile:** include dispatched events in types ([#1695](https://github.com/carbon-design-system/carbon-components-svelte/issues/1695)) ([ca40dd1](https://github.com/carbon-design-system/carbon-components-svelte/commit/ca40dd18c2af1bc755b857c39469427038f20ece)), closes [#1694](https://github.com/carbon-design-system/carbon-components-svelte/issues/1694) -* **text-input:** correctly set input padding for warning state ([#1688](https://github.com/carbon-design-system/carbon-components-svelte/issues/1688)) ([821233a](https://github.com/carbon-design-system/carbon-components-svelte/commit/821233ab4f0bf247dea6a8aa32b79d15424ff059)), closes [#1687](https://github.com/carbon-design-system/carbon-components-svelte/issues/1687) +- **selectable-tile:** include dispatched events in types ([#1695](https://github.com/carbon-design-system/carbon-components-svelte/issues/1695)) ([ca40dd1](https://github.com/carbon-design-system/carbon-components-svelte/commit/ca40dd18c2af1bc755b857c39469427038f20ece)), closes [#1694](https://github.com/carbon-design-system/carbon-components-svelte/issues/1694) +- **text-input:** correctly set input padding for warning state ([#1688](https://github.com/carbon-design-system/carbon-components-svelte/issues/1688)) ([821233a](https://github.com/carbon-design-system/carbon-components-svelte/commit/821233ab4f0bf247dea6a8aa32b79d15424ff059)), closes [#1687](https://github.com/carbon-design-system/carbon-components-svelte/issues/1687) ### [0.73.3](https://github.com/carbon-design-system/carbon-components-svelte/compare/v0.73.2...v0.73.3) (2023-03-11) - ### Bug Fixes -* **1684:** hide helper text container in password input when not used ([#1685](https://github.com/carbon-design-system/carbon-components-svelte/issues/1685)) ([42349eb](https://github.com/carbon-design-system/carbon-components-svelte/commit/42349ebc61fdc8756fc5209d4cb63f4f9a63dce9)) +- **1684:** hide helper text container in password input when not used ([#1685](https://github.com/carbon-design-system/carbon-components-svelte/issues/1685)) ([42349eb](https://github.com/carbon-design-system/carbon-components-svelte/commit/42349ebc61fdc8756fc5209d4cb63f4f9a63dce9)) ### [0.73.2](https://github.com/carbon-design-system/carbon-components-svelte/compare/v0.73.1...v0.73.2) (2023-02-27) - ### Bug Fixes -* `readonly` should override `error` behavior in `TextInput`, `NumberInput` ([#1666](https://github.com/carbon-design-system/carbon-components-svelte/issues/1666)) ([6386c33](https://github.com/carbon-design-system/carbon-components-svelte/commit/6386c33f939b5fa310e8eb5a51412c6151de75d2)), closes [/github.com/carbon-design-system/carbon-components-svelte/pull/1666#pullrequestreview-1314558645](https://github.com/carbon-design-system//github.com/carbon-design-system/carbon-components-svelte/pull/1666/issues/pullrequestreview-1314558645) +- `readonly` should override `error` behavior in `TextInput`, `NumberInput` ([#1666](https://github.com/carbon-design-system/carbon-components-svelte/issues/1666)) ([6386c33](https://github.com/carbon-design-system/carbon-components-svelte/commit/6386c33f939b5fa310e8eb5a51412c6151de75d2)), closes [/github.com/carbon-design-system/carbon-components-svelte/pull/1666#pullrequestreview-1314558645](https://github.com/carbon-design-system//github.com/carbon-design-system/carbon-components-svelte/pull/1666/issues/pullrequestreview-1314558645) ### [0.73.1](https://github.com/carbon-design-system/carbon-components-svelte/compare/v0.73.0...v0.73.1) (2023-02-19) - ### Bug Fixes -* **textinput/passwordinput:** apply aria-describedby to hint text ([b435be4](https://github.com/carbon-design-system/carbon-components-svelte/commit/b435be4f1221b30c9afd7a9e1c6867b38eeadeaa)), closes [#1633](https://github.com/carbon-design-system/carbon-components-svelte/issues/1633) +- **textinput/passwordinput:** apply aria-describedby to hint text ([b435be4](https://github.com/carbon-design-system/carbon-components-svelte/commit/b435be4f1221b30c9afd7a9e1c6867b38eeadeaa)), closes [#1633](https://github.com/carbon-design-system/carbon-components-svelte/issues/1633) ### [0.73.0](https://github.com/carbon-design-system/carbon-components-svelte/compare/v0.72.3...v0.73.0) (2023-02-19) diff --git a/README.md b/README.md index a8ab3a2b..262a7c4f 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ ![GitHub](https://img.shields.io/github/license/ibm/carbon-components-svelte?color=262626&style=for-the-badge) ![npm downloads to date](https://img.shields.io/npm/dt/carbon-components-svelte?color=262626&style=for-the-badge) - Chat with us on Discord +Chat with us on Discord Carbon Components Svelte is a [Svelte](https://github.com/sveltejs/svelte) component library that implements the [Carbon Design System](https://github.com/carbon-design-system), an open source design system by IBM. diff --git a/src/NumberInput/NumberInput.svelte b/src/NumberInput/NumberInput.svelte index e917c303..cf3a3ecb 100644 --- a/src/NumberInput/NumberInput.svelte +++ b/src/NumberInput/NumberInput.svelte @@ -191,8 +191,8 @@ type="number" pattern="[0-9]*" aria-describedby="{errorId}" - data-invalid="{(error) || undefined}" - aria-invalid="{(error) || undefined}" + data-invalid="{error || undefined}" + aria-invalid="{error || undefined}" aria-label="{label ? undefined : ariaLabel}" disabled="{disabled}" id="{id}" From aa2e97f110da8a9284fca9f9381fa5c6d18fc6dc Mon Sep 17 00:00:00 2001 From: Gregor Wassmann Date: Sat, 25 Mar 2023 00:10:50 +0100 Subject: [PATCH 002/562] docs(theme): use `Theme` component from library (#1700) --- docs/src/components/Theme.svelte | 30 ------------------------------ docs/src/pages/_layout.svelte | 5 +++-- 2 files changed, 3 insertions(+), 32 deletions(-) delete mode 100644 docs/src/components/Theme.svelte diff --git a/docs/src/components/Theme.svelte b/docs/src/components/Theme.svelte deleted file mode 100644 index c10ca7ee..00000000 --- a/docs/src/components/Theme.svelte +++ /dev/null @@ -1,30 +0,0 @@ - - - diff --git a/docs/src/pages/_layout.svelte b/docs/src/pages/_layout.svelte index fa1074bb..b506dea7 100644 --- a/docs/src/pages/_layout.svelte +++ b/docs/src/pages/_layout.svelte @@ -12,10 +12,11 @@ SideNav, SideNavItems, SideNavMenuItem, + Theme, Tag, } from "carbon-components-svelte"; import LogoGithub from "carbon-icons-svelte/lib/LogoGithub.svelte"; - import Theme from "../components/Theme.svelte"; + import { theme } from "../store"; const deprecated = []; const new_components = []; @@ -38,7 +39,7 @@ - +
Date: Sun, 26 Mar 2023 05:18:42 +0900 Subject: [PATCH 003/562] docs(tag): fix typo (#1705) --- docs/src/pages/components/Tag.svx | 2 +- docs/src/pages/components/Theme.svx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/src/pages/components/Tag.svx b/docs/src/pages/components/Tag.svx index 85799b6e..b693a713 100644 --- a/docs/src/pages/components/Tag.svx +++ b/docs/src/pages/components/Tag.svx @@ -41,7 +41,7 @@ ## Custom icon -Note: rendering a custom icon cannnot be used with the filterable variant. +Note: rendering a custom icon cannot be used with the filterable variant. IBM Cloud diff --git a/docs/src/pages/components/Theme.svx b/docs/src/pages/components/Theme.svx index f00cb56d..9a5cab2f 100644 --- a/docs/src/pages/components/Theme.svx +++ b/docs/src/pages/components/Theme.svx @@ -12,7 +12,7 @@ The `Theme` component can dyanmically update the Carbon theme on the client-side The `all.css` StyleSheet uses [CSS variables](https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties) for dynamic theming. - + ## Default From 9c1b0c12789807ad264d2e5fd22eca2990d3c240 Mon Sep 17 00:00:00 2001 From: Gregor Wassmann Date: Sun, 26 Mar 2023 18:34:08 +0200 Subject: [PATCH 004/562] docs: fix layout for smaller screens (#1707) Fixes #1649 --- docs/src/global.css | 5 +++++ docs/src/layouts/ComponentLayout.svelte | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/docs/src/global.css b/docs/src/global.css index fd8003b2..e154174f 100644 --- a/docs/src/global.css +++ b/docs/src/global.css @@ -33,6 +33,11 @@ html[theme="g90"] .code-override { overflow-x: auto; } +/* Addig this to the layout grid fixes overstretching. */ +.fix-overflow { + min-width: 0; +} + .token.tag, .token.operator { color: #6ea6ff; diff --git a/docs/src/layouts/ComponentLayout.svelte b/docs/src/layouts/ComponentLayout.svelte index e099d00a..9277ceed 100644 --- a/docs/src/layouts/ComponentLayout.svelte +++ b/docs/src/layouts/ComponentLayout.svelte @@ -66,7 +66,7 @@ - +

{component}

From c00df4021640c8697a37199ee2feb6348c79a23d Mon Sep 17 00:00:00 2001 From: metonym Date: Sun, 26 Mar 2023 12:28:48 -0700 Subject: [PATCH 005/562] chore(a11y): silence new a11y warnings from svelte@3.57 (#1703) * chore(deps-dev): upgrade svelte to 3.57 * chore(deps-dev): upgrade svelte-check * chore(a11y): silence new a11y warnings from svelte@3.57 * Revert "chore(deps-dev): upgrade svelte-check" This reverts commit 78106587a2fd0e1bb07e86afc9fb49f596d2c24a. * fix(progress-step): remove unnecessary `aria-disabled` https://github.com/carbon-design-system/carbon-components-svelte/pull/1703#pullrequestreview-1357928713 --- docs/package.json | 2 +- docs/yarn.lock | 10 +++++----- package.json | 2 +- src/ContextMenu/ContextMenu.svelte | 1 + src/OverflowMenu/OverflowMenu.svelte | 1 + src/ProgressIndicator/ProgressStep.svelte | 1 - src/Tabs/Tabs.svelte | 1 + src/TreeView/TreeView.svelte | 1 + src/TreeView/TreeViewNode.svelte | 1 + src/TreeView/TreeViewNodeList.svelte | 1 + src/UIShell/HeaderNav.svelte | 1 + src/UIShell/HeaderNavMenu.svelte | 1 + src/UIShell/HeaderSearch.svelte | 1 + src/UIShell/SideNavMenu.svelte | 1 + yarn.lock | 10 +++++----- 15 files changed, 22 insertions(+), 13 deletions(-) diff --git a/docs/package.json b/docs/package.json index 71f0550e..0e44fd58 100644 --- a/docs/package.json +++ b/docs/package.json @@ -22,7 +22,7 @@ "prism-svelte": "^0.4.7", "prismjs": "^1.28.0", "remark-slug": "^6.0.0", - "svelte": "^3.49.0", + "svelte": "^3.57.0", "vite": "^3.0.9" }, "routify": { diff --git a/docs/yarn.lock b/docs/yarn.lock index 60209c7b..894928bd 100644 --- a/docs/yarn.lock +++ b/docs/yarn.lock @@ -165,7 +165,7 @@ bufferutil@^4.0.1: node-gyp-build "~3.7.0" carbon-components-svelte@../: - version "0.70.1" + version "0.73.3" dependencies: flatpickr "4.6.9" @@ -1280,10 +1280,10 @@ svelte-hmr@^0.14.12: resolved "https://registry.yarnpkg.com/svelte-hmr/-/svelte-hmr-0.14.12.tgz#a127aec02f1896500b10148b2d4d21ddde39973f" integrity sha512-4QSW/VvXuqVcFZ+RhxiR8/newmwOCTlbYIezvkeN6302YFRE8cXy0naamHcjz8Y9Ce3ITTZtrHrIL0AGfyo61w== -svelte@^3.49.0: - version "3.49.0" - resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.49.0.tgz#5baee3c672306de1070c3b7888fc2204e36a4029" - integrity sha512-+lmjic1pApJWDfPCpUUTc1m8azDqYCG1JN9YEngrx/hUyIcFJo6VZhj0A1Ai0wqoHcEIuQy+e9tk+4uDgdtsFA== +svelte@^3.57.0: + version "3.57.0" + resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.57.0.tgz#a3969cfe51f25f2a55e75f7b98dbd02c3af0980b" + integrity sha512-WMXEvF+RtAaclw0t3bPDTUe19pplMlfyKDsixbHQYgCWi9+O9VN0kXU1OppzrB9gPAvz4NALuoca2LfW2bOjTQ== symbol-tree@^3.2.4: version "3.2.4" diff --git a/package.json b/package.json index 9451373d..3f748ae6 100644 --- a/package.json +++ b/package.json @@ -39,7 +39,7 @@ "sass": "^1.49.11", "standard-version": "^9.5.0", "sveld": "^0.18.0", - "svelte": "^3.51.0", + "svelte": "^3.57.0", "svelte-check": "^2.8.1", "typescript": "^4.7.4" }, diff --git a/src/ContextMenu/ContextMenu.svelte b/src/ContextMenu/ContextMenu.svelte index 68adc47a..80182eb9 100644 --- a/src/ContextMenu/ContextMenu.svelte +++ b/src/ContextMenu/ContextMenu.svelte @@ -153,6 +153,7 @@ }}" /> +