From e1451324cc21ea2f4ac15a08496c646d9c90e365 Mon Sep 17 00:00:00 2001 From: metonym Date: Tue, 17 May 2022 06:24:23 -0700 Subject: [PATCH 001/790] docs: update `Theme`, `DataTable` docs (#1305) * docs(theme): add note that `Theme` must be used with `all.css` * docs(data-table): add note that custom widths do not work with `stickyHeader` --- docs/src/pages/components/DataTable.svx | 4 ++++ docs/src/pages/components/Theme.svx | 14 ++++++++++++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/docs/src/pages/components/DataTable.svx b/docs/src/pages/components/DataTable.svx index f3a933e4..52714f80 100644 --- a/docs/src/pages/components/DataTable.svx +++ b/docs/src/pages/components/DataTable.svx @@ -334,6 +334,10 @@ Specify a `width` or `minWidth` property in the `headers` object to customize th A [table-layout: fixed](https://developer.mozilla.org/en-US/docs/Web/CSS/table-layout#values) rule will be applied to the `table` element when using custom widths. + +
Custom column widths do not work with a sticky header.
+ + ### Sticky header diff --git a/docs/src/pages/components/Theme.svx b/docs/src/pages/components/Theme.svx index 395e077f..d0cdc66f 100644 --- a/docs/src/pages/components/Theme.svx +++ b/docs/src/pages/components/Theme.svx @@ -1,9 +1,19 @@ -This utility component dynamically updates the Carbon theme on the client-side using CSS variables. +The `Theme` component can dyanmically update the Carbon theme on the client-side. It can persist the theme locally using [window.localStorage](https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage). + + +
You must use the "all.css" StyleSheet with the Theme component.
+ + +The `all.css` StyleSheet uses [CSS variables](https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties) for dynamic theming. + + ### Default From cae1f1939e368da3094a6f28050579e3118785d2 Mon Sep 17 00:00:00 2001 From: metonym Date: Wed, 18 May 2022 19:00:21 -0700 Subject: [PATCH 002/790] fix(modal): remove close button `title` attribute, add `aria-hidden` to icons (#1308) * fix(modal): close button should not have a title * fix(modal): close icon should not have aria-label * fix(modal): close button icons should have `aria-hidden="true" --- src/ComposedModal/ModalHeader.svelte | 7 +++++-- src/Modal/Modal.svelte | 14 ++------------ 2 files changed, 7 insertions(+), 14 deletions(-) diff --git a/src/ComposedModal/ModalHeader.svelte b/src/ComposedModal/ModalHeader.svelte index 67d346ae..f3b5c069 100644 --- a/src/ComposedModal/ModalHeader.svelte +++ b/src/ComposedModal/ModalHeader.svelte @@ -50,13 +50,16 @@ diff --git a/src/Modal/Modal.svelte b/src/Modal/Modal.svelte index 643b2bc4..9efbda6f 100644 --- a/src/Modal/Modal.svelte +++ b/src/Modal/Modal.svelte @@ -222,17 +222,12 @@ bind:this="{buttonRef}" type="button" aria-label="{iconDescription}" - title="{iconDescription}" class:bx--modal-close="{true}" on:click="{() => { open = false; }}" > - +