mirror of
https://github.com/carbon-design-system/carbon-components-svelte.git
synced 2025-09-18 11:36:36 +00:00
feat(select): forward change event
Dispatch `input` instead of `change` when props change internally since `change` is a user event and `input` is an internal event
This commit is contained in:
parent
724d90bd7b
commit
29a83c325c
4 changed files with 9 additions and 8 deletions
|
@ -3179,8 +3179,8 @@ None.
|
|||
|
||||
| Event name | Type | Detail |
|
||||
| :--------- | :--------- | :-------------------------------- |
|
||||
| change | dispatched | <code>string | number</code> |
|
||||
| input | forwarded | -- |
|
||||
| input | dispatched | <code>string | number</code> |
|
||||
| change | forwarded | -- |
|
||||
| focus | forwarded | -- |
|
||||
| blur | forwarded | -- |
|
||||
|
||||
|
|
|
@ -10252,8 +10252,8 @@
|
|||
}
|
||||
],
|
||||
"events": [
|
||||
{ "type": "dispatched", "name": "change", "detail": "string | number" },
|
||||
{ "type": "forwarded", "name": "input", "element": "select" },
|
||||
{ "type": "dispatched", "name": "input", "detail": "string | number" },
|
||||
{ "type": "forwarded", "name": "change", "element": "select" },
|
||||
{ "type": "forwarded", "name": "focus", "element": "select" },
|
||||
{ "type": "forwarded", "name": "blur", "element": "select" }
|
||||
],
|
||||
|
|
|
@ -1,6 +1,6 @@
|
|||
<script>
|
||||
/**
|
||||
* @event {string | number} change
|
||||
* @event {string | number} input
|
||||
*/
|
||||
|
||||
/**
|
||||
|
@ -114,7 +114,7 @@
|
|||
selected = $selectedValue;
|
||||
|
||||
if (prevSelected !== undefined && selected !== prevSelected) {
|
||||
dispatch("change", $selectedValue);
|
||||
dispatch("input", $selectedValue);
|
||||
}
|
||||
|
||||
prevSelected = selected;
|
||||
|
@ -163,6 +163,7 @@
|
|||
class:bx--select-input--sm="{size === 'sm'}"
|
||||
class:bx--select-input--xl="{size === 'xl'}"
|
||||
on:change="{handleChange}"
|
||||
on:change
|
||||
on:input
|
||||
on:focus
|
||||
on:blur
|
||||
|
|
4
types/Select/Select.svelte.d.ts
vendored
4
types/Select/Select.svelte.d.ts
vendored
|
@ -109,8 +109,8 @@ export interface SelectProps
|
|||
export default class Select extends SvelteComponentTyped<
|
||||
SelectProps,
|
||||
{
|
||||
change: CustomEvent<string | number>;
|
||||
input: WindowEventMap["input"];
|
||||
input: CustomEvent<string | number>;
|
||||
change: WindowEventMap["change"];
|
||||
focus: WindowEventMap["focus"];
|
||||
blur: WindowEventMap["blur"];
|
||||
},
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue