mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-20 12:23:02 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix some minor bugs

Browse source 
The tabindex variable is of a number type (it should be fixed in all components?)
Add href to link  attributes to get rid of   "<!-- svelte-ignore a11y-missing-attribute -->"
This commit is contained in:
Bilux 2021-11-14 21:03:47 +01:00 • committed by GitHub
commit 2c79f16371
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/OverflowMenu/OverflowMenuItem.svelte
View file

@ -44,7 +44,7 @@
$: primaryFocus = $focusedId === id; $: primaryFocus = $focusedId === id;
$: buttonProps = { $: buttonProps = {
role: "menuitem", role: "menuitem",
tabindex: "-1", tabindex: -1,
class: "bx--overflow-menu-options__btn", class: "bx--overflow-menu-options__btn",
disabled: href ? undefined : disabled, disabled: href ? undefined : disabled,
href: href ? href : undefined, href: href ? href : undefined,
@ -62,9 +62,9 @@
{...$$restProps} {...$$restProps}
> >
{#if href} {#if href}
<!-- svelte-ignore a11y-missing-attribute -->
<a <a
bind:this="{ref}" bind:this="{ref}"
{href}
{...buttonProps} {...buttonProps}
on:click on:click
on:click="{() => { on:click="{() => {