mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-15 18:31:06 +00:00
Code Issues Projects Releases Packages Wiki Activity

chore(combo-box): remove unnecessary selectedId assignments

Browse source 
selectedId is set based on the selectedIndex
This commit is contained in:
Eric Liu 2020-07-28 18:54:18 -07:00
commit 382b2f6e85
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/ComboBox/ComboBox.svelte
View file

@ -233,7 +233,6 @@
open = !open; open = !open;
if (highlightedIndex > -1 && highlightedIndex !== selectedIndex) { if (highlightedIndex > -1 && highlightedIndex !== selectedIndex) {
selectedIndex = highlightedIndex; selectedIndex = highlightedIndex;
selectedId = items[selectedIndex].id;
open = false; open = false;
} }
} else if (key === 'Tab') { } else if (key === 'Tab') {
@ -287,7 +286,6 @@
active={selectedIndex === i || selectedId === item.id} active={selectedIndex === i || selectedId === item.id}
highlighted={highlightedIndex === i || selectedIndex === i} highlighted={highlightedIndex === i || selectedIndex === i}
on:click={() => { on:click={() => {
selectedId = item.id;
selectedIndex = items selectedIndex = items
.map(({ id }) => id) .map(({ id }) => id)
.indexOf(filteredItems[i].id); .indexOf(filteredItems[i].id);