mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-14 18:01:06 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(dropdown): fix ssr issue (#1639)

Browse source 
The `onDestroy` hook is also run during SSR, so returning destruction function from `onMount` should do the trick. For #1638
This commit is contained in:
ptrxyz 2023-01-25 04:28:36 +01:00 • committed by GitHub
commit 8cb5d538f7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/Dropdown/Dropdown.svelte
View file

@ -98,7 +98,7 @@
/** Obtain a reference to the button HTML element */
export let ref = null;
import { createEventDispatcher, onDestroy, onMount } from "svelte";
import { createEventDispatcher, onMount } from "svelte";
import WarningFilled from "../icons/WarningFilled.svelte";
import WarningAltFilled from "../icons/WarningAltFilled.svelte";
import {
@ -159,11 +159,11 @@
if (parent) {
parent.addEventListener("click", pageClickHandler);
}
});
onDestroy(() => {
if (parent) {
parent.removeEventListener("click", pageClickHandler);
return () => {
if (parent) {
parent.removeEventListener("click", pageClickHandler);
}
}
});
</script>