mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-15 02:11:05 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(side-nav-menu): fix a11y warnings

Browse source 
- remove role attributes from SideNavMenuItem
- remove "aria-haspopup" from SideNavMenu
This commit is contained in:
Eric Liu 2020-09-14 06:49:42 -07:00
commit a4d68e7e00
2 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/UIShell/SideNav/SideNavMenu.svelte
View file

@ -24,7 +24,6 @@
<li class:bx--side-nav__item="{true}" class:bx--side-nav__item--icon="{icon}"> <li class:bx--side-nav__item="{true}" class:bx--side-nav__item--icon="{icon}">
<button <button
type="button" type="button"
aria-haspopup="true"
aria-expanded="{expanded}" aria-expanded="{expanded}"
class:bx--side-nav__submenu="{true}" class:bx--side-nav__submenu="{true}"
{...$$restProps} {...$$restProps}

3
src/UIShell/SideNav/SideNavMenuItem.svelte
View file

@ -18,9 +18,8 @@
export let text = undefined; export let text = undefined;
</script> </script>
<li role="none" class:bx--side-nav__menu-item="{true}"> <li class:bx--side-nav__menu-item="{true}">
<a <a
role="menuitem"
aria-current="{isSelected ? 'page' : undefined}" aria-current="{isSelected ? 'page' : undefined}"
href="{href}" href="{href}"
class:bx--side-nav__link="{true}" class:bx--side-nav__link="{true}"