mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-20 20:33:02 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(modal): close button icons should have `aria-hidden="true"

Browse source
This commit is contained in:
Eric Liu 2022-05-18 18:51:58 -07:00
commit bf12ae861b
2 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/ComposedModal/ModalHeader.svelte
View file

@ -56,6 +56,10 @@
on:click on:click
on:click="{closeModal}" on:click="{closeModal}"
> >
<Close size="{20}" class="bx--modal-close__icon {closeIconClass}" /> <Close
size="{20}"
class="bx--modal-close__icon {closeIconClass}"
aria-hidden="true"
/>
</button> </button>
</div> </div>

4
src/Modal/Modal.svelte
View file

@ -227,7 +227,7 @@
open = false; open = false;
}}" }}"
> >
<Close size="{20}" class="bx--modal-close__icon" /> <Close size="{20}" class="bx--modal-close__icon" aria-hidden="true" />
</button> </button>
{/if} {/if}
{#if modalLabel} {#if modalLabel}
@ -248,7 +248,7 @@
open = false; open = false;
}}" }}"
> >
<Close size="{20}" class="bx--modal-close__icon" /> <Close size="{20}" class="bx--modal-close__icon" aria-hidden="true" />
</button> </button>
{/if} {/if}
</div> </div>