chore(a11y): silence new a11y warnings from svelte@3.57 (#1703)

* chore(deps-dev): upgrade svelte to 3.57

* chore(deps-dev): upgrade svelte-check

* chore(a11y): silence new a11y warnings from svelte@3.57

* Revert "chore(deps-dev): upgrade svelte-check"

This reverts commit 78106587a2.

* fix(progress-step): remove unnecessary `aria-disabled`

https://github.com/carbon-design-system/carbon-components-svelte/pull/1703#pullrequestreview-1357928713
This commit is contained in:
metonym 2023-03-26 12:28:48 -07:00 committed by GitHub
commit c00df40216
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
15 changed files with 22 additions and 13 deletions

View file

@ -22,7 +22,7 @@
"prism-svelte": "^0.4.7", "prism-svelte": "^0.4.7",
"prismjs": "^1.28.0", "prismjs": "^1.28.0",
"remark-slug": "^6.0.0", "remark-slug": "^6.0.0",
"svelte": "^3.49.0", "svelte": "^3.57.0",
"vite": "^3.0.9" "vite": "^3.0.9"
}, },
"routify": { "routify": {

View file

@ -165,7 +165,7 @@ bufferutil@^4.0.1:
node-gyp-build "~3.7.0" node-gyp-build "~3.7.0"
carbon-components-svelte@../: carbon-components-svelte@../:
version "0.70.1" version "0.73.3"
dependencies: dependencies:
flatpickr "4.6.9" flatpickr "4.6.9"
@ -1280,10 +1280,10 @@ svelte-hmr@^0.14.12:
resolved "https://registry.yarnpkg.com/svelte-hmr/-/svelte-hmr-0.14.12.tgz#a127aec02f1896500b10148b2d4d21ddde39973f" resolved "https://registry.yarnpkg.com/svelte-hmr/-/svelte-hmr-0.14.12.tgz#a127aec02f1896500b10148b2d4d21ddde39973f"
integrity sha512-4QSW/VvXuqVcFZ+RhxiR8/newmwOCTlbYIezvkeN6302YFRE8cXy0naamHcjz8Y9Ce3ITTZtrHrIL0AGfyo61w== integrity sha512-4QSW/VvXuqVcFZ+RhxiR8/newmwOCTlbYIezvkeN6302YFRE8cXy0naamHcjz8Y9Ce3ITTZtrHrIL0AGfyo61w==
svelte@^3.49.0: svelte@^3.57.0:
version "3.49.0" version "3.57.0"
resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.49.0.tgz#5baee3c672306de1070c3b7888fc2204e36a4029" resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.57.0.tgz#a3969cfe51f25f2a55e75f7b98dbd02c3af0980b"
integrity sha512-+lmjic1pApJWDfPCpUUTc1m8azDqYCG1JN9YEngrx/hUyIcFJo6VZhj0A1Ai0wqoHcEIuQy+e9tk+4uDgdtsFA== integrity sha512-WMXEvF+RtAaclw0t3bPDTUe19pplMlfyKDsixbHQYgCWi9+O9VN0kXU1OppzrB9gPAvz4NALuoca2LfW2bOjTQ==
symbol-tree@^3.2.4: symbol-tree@^3.2.4:
version "3.2.4" version "3.2.4"

View file

@ -39,7 +39,7 @@
"sass": "^1.49.11", "sass": "^1.49.11",
"standard-version": "^9.5.0", "standard-version": "^9.5.0",
"sveld": "^0.18.0", "sveld": "^0.18.0",
"svelte": "^3.51.0", "svelte": "^3.57.0",
"svelte-check": "^2.8.1", "svelte-check": "^2.8.1",
"typescript": "^4.7.4" "typescript": "^4.7.4"
}, },

View file

@ -153,6 +153,7 @@
}}" }}"
/> />
<!-- svelte-ignore a11y-no-noninteractive-element-to-interactive-role -->
<ul <ul
bind:this="{ref}" bind:this="{ref}"
role="menu" role="menu"

View file

@ -242,6 +242,7 @@
/> />
</slot> </slot>
{#if open} {#if open}
<!-- svelte-ignore a11y-no-noninteractive-element-to-interactive-role -->
<ul <ul
bind:this="{menuRef}" bind:this="{menuRef}"
role="menu" role="menu"

View file

@ -53,7 +53,6 @@
<!-- svelte-ignore a11y-mouse-events-have-key-events --> <!-- svelte-ignore a11y-mouse-events-have-key-events -->
<li <li
aria-disabled="{disabled}"
id="{id}" id="{id}"
class:bx--progress-step="{true}" class:bx--progress-step="{true}"
class:bx--progress-step--current="{current}" class:bx--progress-step--current="{current}"

View file

@ -151,6 +151,7 @@
</a> </a>
<ChevronDown aria-hidden="true" title="{iconDescription}" /> <ChevronDown aria-hidden="true" title="{iconDescription}" />
</div> </div>
<!-- svelte-ignore a11y-no-noninteractive-element-to-interactive-role -->
<ul <ul
bind:this="{refTabList}" bind:this="{refTabList}"
role="tablist" role="tablist"

View file

@ -188,6 +188,7 @@
</label> </label>
{/if} {/if}
<!-- svelte-ignore a11y-no-noninteractive-element-to-interactive-role -->
<ul <ul
{...$$restProps} {...$$restProps}
role="tree" role="tree"

View file

@ -75,6 +75,7 @@
} }
</script> </script>
<!-- svelte-ignore a11y-no-noninteractive-element-to-interactive-role -->
<li <li
bind:this="{ref}" bind:this="{ref}"
role="treeitem" role="treeitem"

View file

@ -72,6 +72,7 @@
{/if} {/if}
{/each} {/each}
{:else} {:else}
<!-- svelte-ignore a11y-no-noninteractive-element-to-interactive-role -->
<li <li
bind:this="{ref}" bind:this="{ref}"
role="treeitem" role="treeitem"

View file

@ -6,6 +6,7 @@
</script> </script>
<nav {...props} class:bx--header__nav="{true}" {...$$restProps}> <nav {...props} class:bx--header__nav="{true}" {...$$restProps}>
<!-- svelte-ignore a11y-no-noninteractive-element-to-interactive-role -->
<ul {...props} role="menubar" class:bx--header__menu-bar="{true}"> <ul {...props} role="menubar" class:bx--header__menu-bar="{true}">
<slot /> <slot />
</ul> </ul>

View file

@ -94,6 +94,7 @@
{text} {text}
<ChevronDown class="bx--header__menu-arrow" /> <ChevronDown class="bx--header__menu-arrow" />
</a> </a>
<!-- svelte-ignore a11y-no-noninteractive-element-to-interactive-role -->
<ul <ul
bind:this="{menuRef}" bind:this="{menuRef}"
role="menu" role="menu"

View file

@ -134,6 +134,7 @@
</div> </div>
{#if active && results.length > 0} {#if active && results.length > 0}
<!-- svelte-ignore a11y-no-noninteractive-element-to-interactive-role -->
<ul aria-labelledby="search-label" role="menu" id="search-menu"> <ul aria-labelledby="search-label" role="menu" id="search-menu">
{#each results as result, i} {#each results as result, i}
<li role="none"> <li role="none">

View file

@ -48,6 +48,7 @@
<ChevronDown /> <ChevronDown />
</div> </div>
</button> </button>
<!-- svelte-ignore a11y-no-noninteractive-element-to-interactive-role -->
<ul <ul
role="menu" role="menu"
class:bx--side-nav__menu="{true}" class:bx--side-nav__menu="{true}"

View file

@ -2018,16 +2018,16 @@ svelte-preprocess@^4.10.6:
sorcery "^0.10.0" sorcery "^0.10.0"
strip-indent "^3.0.0" strip-indent "^3.0.0"
svelte@^3.51.0:
version "3.51.0"
resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.51.0.tgz#a1a0afb25dc518217f353dd73ea6471c128ddf84"
integrity sha512-PBITYIrsNOuW+Dtds00gSY68raNZQn7i59Dg/fjgf6WwyawPKeBwle692coO7ILZqSO+UJe9899aDn9sMdeOHA==
svelte@^3.52.0: svelte@^3.52.0:
version "3.54.0" version "3.54.0"
resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.54.0.tgz#b4bcd865bd9e927f9f7b76563288ef5f4d72867a" resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.54.0.tgz#b4bcd865bd9e927f9f7b76563288ef5f4d72867a"
integrity sha512-tdrgeJU0hob0ZWAMoKXkhcxXA7dpTg6lZGxUeko5YqvPdJBiyRspGsCwV27kIrbrqPP2WUoSV9ca0gnLlw8YzQ== integrity sha512-tdrgeJU0hob0ZWAMoKXkhcxXA7dpTg6lZGxUeko5YqvPdJBiyRspGsCwV27kIrbrqPP2WUoSV9ca0gnLlw8YzQ==
svelte@^3.57.0:
version "3.57.0"
resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.57.0.tgz#a3969cfe51f25f2a55e75f7b98dbd02c3af0980b"
integrity sha512-WMXEvF+RtAaclw0t3bPDTUe19pplMlfyKDsixbHQYgCWi9+O9VN0kXU1OppzrB9gPAvz4NALuoca2LfW2bOjTQ==
terser@^5.0.0: terser@^5.0.0:
version "5.14.2" version "5.14.2"
resolved "https://registry.yarnpkg.com/terser/-/terser-5.14.2.tgz#9ac9f22b06994d736174f4091aa368db896f1c10" resolved "https://registry.yarnpkg.com/terser/-/terser-5.14.2.tgz#9ac9f22b06994d736174f4091aa368db896f1c10"