Commit graph

952 commits

Author SHA1 Message Date
Carson McCue
b435be4f12
fix(textinput/passwordinput): apply aria-describedby to hint text
* Aria-describedby

Resolves base aria-describedby attribute from #1633.

* Update PasswordInput.svelte
2023-02-19 14:53:00 -05:00
Jonathan Quintin
7ddbf17cbb
feat(progress-bar): add status prop (#1560)
* ProgressBar status feature added

* ProgressBar: Removed the css variables and use carbon-css instead.
The way of assigning the ProgressBar value has change. It is now a style
variable and scale-x is calculated in the css. This way prevent the
override of carbon css.

* Removed an unessacery span.

* Removed an unnecessary span.

* Added the status for the ProgressBarUx

* Remove `style css` and update docs.

* - Fixed the `capped` variable for more readability
- Updated docs `label` and `helperText`
- Updated docs and css

* fix: finished/error states cannot be indeterminate

* Run "yarn build:css"

* Re-run "yarn build:docs"

* test(progress-bar): assert `status` prop

* chore: add aria-busy and set valuenow to 0 when not active

---------

Co-authored-by: Eric Liu <ericyl.us@gmail.com>
Co-authored-by: Enrico Sacchetti <enrico@theetrain.ca>
2023-02-19 12:34:41 -05:00
metonym
6450e8b0b1
fix(types): add missing $$restProps for Checkbox, Filename, FluidForm (#1655)
* fix(types): add missing `$$restProps` for `Checkbox`, `Filename`, `FluidForm`

* Run "yarn build:docs"

* test: assert `$$restProps` for `Checkbox`, `Form`
2023-02-11 13:50:01 -05:00
metonym
d897484abf
fix(dropdown): dispatch correct selectedItem in select event (#1646)
Fixes #1645
2023-02-04 20:31:31 -05:00
ptrxyz
8cb5d538f7
fix(dropdown): fix ssr issue (#1639)
The `onDestroy` hook is also run during SSR, so returning destruction function from `onMount` should do the trick. For #1638
2023-01-24 22:28:36 -05:00
Jonathan Quintin
73aa6e216a
fix(dropdown): close when user clicks outside iframe (#1596)
* `Dropdown` click outside
Fixes #1595

* `onDestroy` we want to remove the event listener
to prevent listeners hanging
2023-01-17 20:57:50 -05:00
metonym
ec867c46ba
fix(tree-view)!: remove expanded property from TreeNode interface (#1631)
* fix(tree-view)!: remove `expanded` property from `TreeNode`

* fix(tree-view-node-list)!: remove unused `expanded` prop

* docs(tree-view): remove `expanded` as a property

#1630
2023-01-17 20:55:46 -05:00
Enrico Sacchetti
6d2e21f027
chore: improve lint, release workflows (#1627)
* Add standard-version to automate releases

* Remove husky

* Add lint script; run lint in GitHub Actions

* Run lint script

* Add Enrico to contributors
2023-01-15 15:34:09 -08:00
Enrico Sacchetti
50066966da
feat(notification)!: replace iconDescription prop with statusIconDescription, closeButtonDescription (#1591)
Fixes #672, fixes #1563

* breaking: remove `iconDescription` prop from `InlineNotification`, `ToastNotification`

* breaking: require `iconDescription` prop in `NotificationIcon`

* feat: add new `statusIconDescription` and `closeButtonDescription` to `InlineNotification`, `ToastNotification`
2022-12-18 15:28:23 -08:00
Enrico Sacchetti
8d55752a18
fix(pagination-nav)!: use 1-indexing to be consistent with Pagination (#1518)
Fixes #1513
2022-12-13 10:23:04 -08:00
Enrico Sacchetti
9198ed5474
feat!: dispatch "change" event in Pagination, rename "change" to "update" in Select (#1497)
Closes #1491

* feat(pagination): dispatch "change" event when interacting with previous/next buttons, page/page size dropdowns

* breaking(select): rename dispatched "change" event to "update"

* breaking(select): forward `change` event to `Select`
2022-12-13 10:22:17 -08:00
metonym
fce92fb648
fix(dropdown): avoid runtime error if items is empty (#1578) 2022-12-07 20:38:22 -08:00
metonym
4b503c8c35
fix(multi-select): avoid runtime error if items is empty (#1577) 2022-12-07 20:34:46 -08:00
Bilux
09b3eed582
fix(combobox): avoid runtime error if items is empty (#1545) 2022-12-07 20:29:04 -08:00
metonym
837716ff8b fix(overflow-menu): dispatch "close" event when clicking outside (#1546)
Fixes #1541
2022-12-07 20:25:47 -08:00
David Wolf
ba62f45d34
fix(table-header): button should have explicit type="button" (#1573) 2022-12-07 20:14:47 -08:00
Maxime Fafard
0f8a57b9d2
fix(popover): fire "click:outside" event when clicking sibling elements (#1570) 2022-12-07 20:10:45 -08:00
Enrico Sacchetti
fa5515ded0
fix(dropdown): only dispatch "select" on interaction, allow arrow keys to navigate menu (#1569)
Fixes #1475
2022-12-07 20:09:29 -08:00
Eric Liu
a0600e8bdb chore(number-input): ensure value is a number
Fast-follow to #1555. `ref.value` remains a string if not converted to a number.
2022-12-07 20:07:49 -08:00
Jonathan Quintin
e6f5766e46
fix(number-input): support floating point values (#1555)
Fixes #233, fixes #486, fixes #1554
2022-12-07 20:06:29 -08:00
Jonathan Quintin
e7fe8ca85b
fix(toggle): forward change, keyup events after toggled updates (#1559)
Fixes #1556
2022-12-07 20:05:20 -08:00
brunnerh
75a69bbfc2
fix(progress-step): fix label text if vertical is true (#1533)
Fixes #1532
2022-12-07 20:03:34 -08:00
brunnerh
7a98ec26eb
fix(progress-step): inherit unclickable styling if preventChangeOnClick is true (#1535)
Fixes #1534
2022-12-07 20:02:24 -08:00
Tadeáš Maršík
bf337c48ae
fix(progress-step): button should have explicit type="button" (#1551)
Fixes #1550
2022-12-07 20:01:29 -08:00
metonym
198e0da4c5
fix(tree-view): loosen TreeNode text property type to any (#1576)
* fix(tree-view): loosen `TreeNode` text property type to any

* Run "yarn build:docs"

* test(tree-view): assert updated property type value
2022-12-07 20:00:20 -08:00
DetachHead
21d841feeb
fix(tree-view): make TreeView children prop type work recursively (#1566) 2022-12-07 19:54:14 -08:00
Bilux
ae34451583
fix(data-table): remove unused import from "svelte/store" (#1529) 2022-10-20 10:21:12 -07:00
metonym
1c4ee00142
fix(search): prop types should extend input attributes (#1523)
Fixes #1520
2022-10-13 22:04:32 -07:00
metonym
c6373dc9b6
fix(a11y): ignore false positive a11y warnings (#1522)
Fixes #1517
2022-10-13 21:37:52 -07:00
Paweł Malinowski
5723ffef02
fix(number-input): allowEmpty should not be invalid if value is null (#1511)
Fixes #1510
2022-10-13 21:24:55 -07:00
metonym
affeb2e2f4
fix(list-box-menu-item): avoid element reference error (#1507)
Fixes #1505
Fixes #1503
2022-10-03 19:08:07 -07:00
metonym
a657b6e334
fix(date-picker): display warn/invalid icons in input with calendar (#1508)
Fixes #1498
2022-10-03 19:07:48 -07:00
metonym
139e23fdcc
fix(header-search): fix layout regression (#1506)
Fixes #1504
2022-10-03 18:33:30 -07:00
Tee Ming
e900b47ff0
fix: localize HeaderAction, ImageLoader transitions (#1502) 2022-10-03 18:33:04 -07:00
metonym
1a65882973
fix(button): resolve visual regression in Pagination, PaginationNav (#1495) 2022-09-23 07:15:01 -07:00
Ben Periton
bd8741e45b
fix(toolbar-search): forward keyup, keydown, paste events to Search (#1490) 2022-09-21 08:25:27 -07:00
Tadeáš Maršík
ec039ba163
fix(modal): prevent submit event on Modal if primaryButtonDisabled is true (#1486)
Fixes #1485
2022-09-17 10:30:33 -07:00
metonym
73385bf598
fix(a11y): resolve accessibility warnings in Svelte 3.50.0 (#1480)
Fixes #1479

* chore(deps-dev): upgrade svelte 3.47.0 -> 3.50.0

* fix(toggle): ignore `a11y-role-has-required-aria-props` warning

* fix(header-search): resolve a11y warnings
2022-09-05 08:22:58 -07:00
metonym
7c1ca3fa74
fix(button): avoid left margin style for icon-only buttons (#1477)
Fixes #1476
2022-09-02 08:36:39 -07:00
metonym
edf33ca2d2
fix(list-box-menu-item): do not scroll entire page when using keyboard navigation (#1474) 2022-08-31 19:25:51 -07:00
metonym
855ee06741
fix: pressing "Escape" should close Dropdown, MultiSelect menu (#1473)
* fix(dropdown): close the menu when pressing "Escape"

* fix(multi-select): close the menu when pressing "Escape"
2022-08-31 19:00:01 -07:00
metonym
1a7f750093
fix(combo-box): prevent default behavior when pressing Enter/ArrowUp/ArrowDown (#1472) 2022-08-31 18:54:08 -07:00
metonym
7030300186
fix(list-box-menu-item): scroll item into view when using keyboard navigation (#1471)
Fixes #1470
2022-08-31 18:52:06 -07:00
metonym
7bfa92d5c0
fix(ui-shell): allow $$restProps.style to be applied to Content (#1468)
Fixes #1467
2022-08-29 08:08:43 -07:00
metonym
5bafda10f9
fix(ui-shell): do not unset Content left margin for rail SideNav (#1462)
Fixes #1459
2022-08-23 07:57:56 -07:00
metonym
1e9a34808f
fix(date-picker): set role, aria-label attributes on calendar container (#1461)
Ref: 6b57099f46/packages/react/src/components/DatePicker/DatePicker.js (L385-L390)
2022-08-23 07:57:40 -07:00
metonym
dbe33d5cbb
feat(toolbar-search): add filteredRowIds prop to support pagination (#1454)
Closes #1393

* feat(toolbar-search): add `filteredRowIds` prop

* Run "yarn build:docs"

* test(data-table): assert `filteredRowIds` prop

* docs(data-table): add pagination to default filterable examples
2022-08-18 06:59:14 -07:00
metonym
f794cb5312
feat(data-table): dispatch on:click:header--select event (#1453)
* feat(data-table): dispatch `on:click:header--select` event

* Run "yarn build:docs"
2022-08-17 10:19:31 -07:00
naegelin
30487128b3
feat(data-table): dispatch on:click:row--select event (#1450) 2022-08-17 06:39:03 -07:00
metonym
8fea168ffd
feat(toast-notification): add fullWidth prop (#1444)
* feat(toast-notification): add `fullWidth` prop

* Run "yarn build:docs"

* test(toast-notification): assert `fullWidth` prop

* docs(toast-notification): add "Full width" example
2022-08-14 14:56:02 -07:00