Commit graph

920 commits

Author SHA1 Message Date
metonym
139e23fdcc
fix(header-search): fix layout regression (#1506)
Fixes #1504
2022-10-03 18:33:30 -07:00
Tee Ming
e900b47ff0
fix: localize HeaderAction, ImageLoader transitions (#1502) 2022-10-03 18:33:04 -07:00
metonym
1a65882973
fix(button): resolve visual regression in Pagination, PaginationNav (#1495) 2022-09-23 07:15:01 -07:00
Ben Periton
bd8741e45b
fix(toolbar-search): forward keyup, keydown, paste events to Search (#1490) 2022-09-21 08:25:27 -07:00
Tadeáš Maršík
ec039ba163
fix(modal): prevent submit event on Modal if primaryButtonDisabled is true (#1486)
Fixes #1485
2022-09-17 10:30:33 -07:00
metonym
73385bf598
fix(a11y): resolve accessibility warnings in Svelte 3.50.0 (#1480)
Fixes #1479

* chore(deps-dev): upgrade svelte 3.47.0 -> 3.50.0

* fix(toggle): ignore `a11y-role-has-required-aria-props` warning

* fix(header-search): resolve a11y warnings
2022-09-05 08:22:58 -07:00
metonym
7c1ca3fa74
fix(button): avoid left margin style for icon-only buttons (#1477)
Fixes #1476
2022-09-02 08:36:39 -07:00
metonym
edf33ca2d2
fix(list-box-menu-item): do not scroll entire page when using keyboard navigation (#1474) 2022-08-31 19:25:51 -07:00
metonym
855ee06741
fix: pressing "Escape" should close Dropdown, MultiSelect menu (#1473)
* fix(dropdown): close the menu when pressing "Escape"

* fix(multi-select): close the menu when pressing "Escape"
2022-08-31 19:00:01 -07:00
metonym
1a7f750093
fix(combo-box): prevent default behavior when pressing Enter/ArrowUp/ArrowDown (#1472) 2022-08-31 18:54:08 -07:00
metonym
7030300186
fix(list-box-menu-item): scroll item into view when using keyboard navigation (#1471)
Fixes #1470
2022-08-31 18:52:06 -07:00
metonym
7bfa92d5c0
fix(ui-shell): allow $$restProps.style to be applied to Content (#1468)
Fixes #1467
2022-08-29 08:08:43 -07:00
metonym
5bafda10f9
fix(ui-shell): do not unset Content left margin for rail SideNav (#1462)
Fixes #1459
2022-08-23 07:57:56 -07:00
metonym
1e9a34808f
fix(date-picker): set role, aria-label attributes on calendar container (#1461)
Ref: 6b57099f46/packages/react/src/components/DatePicker/DatePicker.js (L385-L390)
2022-08-23 07:57:40 -07:00
metonym
dbe33d5cbb
feat(toolbar-search): add filteredRowIds prop to support pagination (#1454)
Closes #1393

* feat(toolbar-search): add `filteredRowIds` prop

* Run "yarn build:docs"

* test(data-table): assert `filteredRowIds` prop

* docs(data-table): add pagination to default filterable examples
2022-08-18 06:59:14 -07:00
metonym
f794cb5312
feat(data-table): dispatch on:click:header--select event (#1453)
* feat(data-table): dispatch `on:click:header--select` event

* Run "yarn build:docs"
2022-08-17 10:19:31 -07:00
naegelin
30487128b3
feat(data-table): dispatch on:click:row--select event (#1450) 2022-08-17 06:39:03 -07:00
metonym
8fea168ffd
feat(toast-notification): add fullWidth prop (#1444)
* feat(toast-notification): add `fullWidth` prop

* Run "yarn build:docs"

* test(toast-notification): assert `fullWidth` prop

* docs(toast-notification): add "Full width" example
2022-08-14 14:56:02 -07:00
metonym
b04a281939
fix(toolbar-batch-actions): active prop should be reactive (#1445)
Follow-up to #1440
2022-08-14 14:55:38 -07:00
naegelin
06777ba803
feat(toolbar-batch-actions): dispatch cancelable on:cancel event (#1441)
Closes #1438
2022-08-14 12:09:40 -07:00
naegelin
bc58c7b029
feat(toolbar-batch-actions): add active prop to show toolbar (#1440)
Closes #1438
2022-08-12 08:01:58 -07:00
Piper McCorkle
b6e4d133da
fix(notification-action-button): prop types should extend Button (#1442) 2022-08-11 18:45:41 -07:00
metonym
4fd08cd25c
fix(inline-checkbox): remove aria-checked="mixed" if indeterminate (#1436)
Ref: https://github.com/carbon-design-system/carbon/pull/11908
2022-08-10 07:44:08 -07:00
metonym
b4ffed9044 fix(slider): add aria-labelledby to slider thumb (#1435)
Ref: https://github.com/carbon-design-system/carbon/pull/11798
2022-08-10 07:42:41 -07:00
Bert B
c95e2bcc80
fix(toggle): add role="switch" to input (#1434) 2022-08-10 07:05:54 -07:00
metonym
fd42cb3891
fix(ui-shell): remove Content left margin if SideNav is collapsed (#1428)
Fixes #1145
Alternative to #1406
2022-08-06 08:27:45 -07:00
metonym
45f14f160e
refactor: use class directive in TextInput, DatePickerInput (#1426)
Dynamically-formed class names should be avoided for easier static analysis. The Svelte `class:` directive should be used instead.
2022-08-05 05:21:49 -07:00
metonym
d2cc75d883
fix(notification): avoid dynamic class names in NotificationButton, NotificationIcon (#1425)
Fixes https://github.com/carbon-design-system/carbon-preprocess-svelte/issues/39
2022-08-05 05:20:21 -07:00
metonym
7fe9b39436
fix(number-input): forward keydown, keyup events (#1424)
Fixes #1421

`NumberInput` should forward the keydown and keyup events like other input components.
2022-08-05 04:50:40 -07:00
István Pató
de81ef99af
fix(combo-box): correctly select item in a non-filterable ComboBox (#1419)
Fixes #1222

A non-filterable ComboBox will select the item that matches the typed value when pressing "Enter." An unknown (unmatched) value will select the first item.
2022-08-04 09:58:32 -07:00
metonym
8a40191c76
fix(toggle): override margin top if hideLabel is true (#1417)
Fixes #1413
2022-07-26 08:19:49 -07:00
metonym
7f7bf51f56
fix(pagination): correctly pluralize default item text (#1416)
Fixes #1412
2022-07-26 07:59:40 -07:00
metonym
a3264bd667
fix(toggle): labelText should not be selectable (#1415)
This adds a `user-select: none` rule to avoid selecting the `Toggle` label text when rapidly clicking it.
2022-07-26 07:21:19 -07:00
metonym
f4d12b805a
fix(toggle): add missing hideLabel prop (#1414)
* fix(toggle): add missing hideLabel prop

* Run "yarn build:docs"

* test(toggle): assert hideLabel prop

* docs(toggle): add "Hidden label text" example
2022-07-26 07:12:57 -07:00
Johannes
8bd615b250
fix(combobox): value should call itemToString with filtered item (#1411)
Fixes #1405

When using the `shouldFilterItem` prop, the `ComboBox` does not display the custom label set with `itemToString` in the input after a selection.
2022-07-23 06:15:11 -07:00
metonym
638a43714f
fix(side-nav): set high z-index on open overlay (#1388)
Fixes #786

The UI Shell `SideNav` overlay can sometimes be superseded by other elements. This applies a `z-index` value of `6000` to the overlay when open.
2022-07-12 19:43:45 -07:00
metonym
aee7f3ba76
Revert "Revert "fix(notification): on:close should be cancellable (#1379)" (#1381)" (#1382)
This reverts commit 052acfc2ce.
2022-06-29 11:11:33 -07:00
metonym
052acfc2ce
Revert "fix(notification): on:close should be cancellable (#1379)" (#1381)
This reverts commit 924b6d352e.
2022-06-29 10:57:37 -07:00
tlkh40
924b6d352e
fix(notification): on:close should be cancellable (#1379)
Fixes #927
2022-06-29 07:08:51 -07:00
metonym
5a8bd9ca57
chore(code-snippet): preserve custom copy event type (#1375) 2022-06-27 05:44:05 -07:00
metonym
c346b8edc0
fix(side-nav-menu): remove title attribute from menu icon (#1373) 2022-06-26 13:56:08 -07:00
metonym
d5d6294b02
refactor(code-snippet): pass required text prop to CopyButton (#1372)
This also passes the `copy` prop to `CopyButton` instead of wrapping it in another function.
2022-06-25 16:26:27 -07:00
metonym
6a3614bf55
fix(password-input): support invalid state when used in a FluidForm (#1371)
* fix(password-input): support invalid state when used in a `FluidForm`

* docs(fluid-form): add example "Invalid state"
2022-06-25 08:17:19 -07:00
metonym
83c11fd460
fix(side-nav-menu): chevron icon should not be focusable (#1369) 2022-06-23 05:55:01 -07:00
metonym
388a05c290
fix(side-nav-menu): expanded SideNavMenu should not have a max-height (#1368)
* fix(side-nav-menu): expanded `SideNavMenu` should not have a max-height (fixes #1361)

* chore(docs): remove max-height override
2022-06-23 05:52:02 -07:00
metonym
9fcf9855e6
fix(composed-modal): node to focus is possibly null (#1364)
Fixes #1360
2022-06-22 06:24:02 -07:00
metonym
1ccdf64504
feat(slider): add fullWidth prop (#1354)
The `bx--slider` class in the `Slider` component has max-width of `40rem`. Because `$$restProps` is spread to the top-level `div` element in `Slider`, the only way to override the style is to do so globally:

```css
:global(.bx--slider-container) {
  width: 100%;
}

:global(.bx--slider) {
  max-width: none;
}
```

This adds a `fullWidth` prop that sets a full width style using inline style attributes.
2022-06-18 12:47:10 -07:00
metonym
511d7c24e6
fix(select): do not dispatch "change" event on initial load (#1356)
Follow-up to #1353

If `selected` is `undefined` or not provided, the "change" event will be dispatched since the first `SelectItem` value will be set as the default.

The "change" event should only be dispatched when the value is actually changed.
2022-06-18 12:27:27 -07:00
metonym
b4d0205080
chore(select): update dispatched change event type (#1357)
Follow-up to #1355
2022-06-18 12:26:46 -07:00
metonym
78d3f1328a
feat(select): support selected prop number type (#1355)
* feat(select): support number type

* Run "yarn build:docs"

* refactor(pagination): do not coerce `pageSize`, `page` to be numbers

* test(select): assert selected prop number type
2022-06-18 11:09:41 -07:00