Commit graph

920 commits

Author SHA1 Message Date
Eric Liu
2715ed9c38 chore(ui-shell): update company prop description in Header (#1770) 2023-07-13 10:50:51 -07:00
Eric Liu
b015d76f15 chore(a11y): ignore svelte@4 a11y warnings (#1769) 2023-07-13 10:50:51 -07:00
Nestor Orest Plysyuk
ea9b261b60
feat(ui-shell): add preventCloseOnClickOutside to HeaderAction (#1625)
Closes #1624
2023-07-13 07:37:21 -07:00
Janos Lengyel
9b3f014a0b
feat(ui-shell): make company in Header slottable (#1764) 2023-07-13 07:33:48 -07:00
Eric Liu
7579c032fa
fix(select): hide helperText if invalid or warning state (#1761) 2023-07-08 11:29:05 -07:00
Superior
ab21c89ab9
fix(slider): disabled Slider should not submit a form (#1758)
A single disabled input should not submit a form. If there are other non-disabled inputs in the same form, the value of the disabled input should not be included upon form submission.
2023-07-04 09:02:50 -07:00
Ben Periton
d5a4a8b94a
fix(date-picker): hide helperText if invalid or warning state (#1759) 2023-07-03 12:14:23 -07:00
Sachin
0b4f19c87e
feat: make titleText slottable in MultiSelect, ComboBox (#1750)
Closes #1747
2023-06-11 18:45:55 -07:00
Eric Liu
a369962fdf
fix(expandable-tile): set tile height using resize observer (#1738)
* fix(expandable-tile): set tile max height using Resize Observer

* docs(expandable-tile): update and re-work examples
2023-06-02 13:08:25 -04:00
Sam
60a796ea48
feat(pagination-nav): add tooltipPosition prop (#1733)
* Add `tooltipPosition` to `PaginationNav` per #1656

* Rebuild test

* Update description in documentation

Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>

* chore: update docs

---------

Co-authored-by: Samuel Janda <hi@simpleprogramming.com.au>
Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>
Co-authored-by: Enrico Sacchetti <enrico@theetrain.ca>
2023-05-21 13:59:53 -04:00
Eric Liu
c02b4738bc
fix: resolve a11y warnings from Svelte version 3.58 (#1732)
* chore(deps-dev): upgrade svelte to 3.58

* chore(a11y): ignore false positives

Referencing the upstream Carbon React implementation, these warnings can be ignored.

* fix(list-box-menu-item): set `tabindex` to `-1`

* chore: fix `tabindex` capitalization

The Svelte Language server does not detect `tabIndex` as a valid attribute.

Note, however, that `tabIndex` is correct when using it in JavaScript (e.g., `node.tabIndex`).
2023-05-18 14:53:17 -04:00
Pierre
b9aaa3adca
feat(ui-shell): make HeaderNavItem slottable (#1693) 2023-05-02 16:23:04 -07:00
metonym
c00df40216
chore(a11y): silence new a11y warnings from svelte@3.57 (#1703)
* chore(deps-dev): upgrade svelte to 3.57

* chore(deps-dev): upgrade svelte-check

* chore(a11y): silence new a11y warnings from svelte@3.57

* Revert "chore(deps-dev): upgrade svelte-check"

This reverts commit 78106587a2.

* fix(progress-step): remove unnecessary `aria-disabled`

https://github.com/carbon-design-system/carbon-components-svelte/pull/1703#pullrequestreview-1357928713
2023-03-26 15:28:48 -04:00
Gregor Wassmann
14f23962c3
chore: run yarn lint (#1701) 2023-03-24 15:48:00 -07:00
metonym
ca40dd18c2
fix(selectable-tile): include dispatched events in types (#1695)
Fixes #1694
2023-03-20 21:27:29 -04:00
Hyunseung
821233ab4f
fix(text-input): correctly set input padding for warning state (#1688)
Fixes #1687
2023-03-15 10:23:59 -07:00
gabrielleecredera
42349ebc61
fix(1684): hide helper text container in password input when not used (#1685) 2023-03-11 14:38:44 -05:00
metonym
6386c33f93
fix: readonly should override error behavior in TextInput, NumberInput (#1666)
* fix(text-input): avoid overlapping readonly/invalid icons

* fix(number-input): avoid overlapping readonly/invalid icons

* fix: readonly inputs cannot be invalid

Addresses https://github.com/carbon-design-system/carbon-components-svelte/pull/1666#pullrequestreview-1314558645
2023-02-26 20:51:50 -05:00
Carson McCue
b435be4f12
fix(textinput/passwordinput): apply aria-describedby to hint text
* Aria-describedby

Resolves base aria-describedby attribute from #1633.

* Update PasswordInput.svelte
2023-02-19 14:53:00 -05:00
Jonathan Quintin
7ddbf17cbb
feat(progress-bar): add status prop (#1560)
* ProgressBar status feature added

* ProgressBar: Removed the css variables and use carbon-css instead.
The way of assigning the ProgressBar value has change. It is now a style
variable and scale-x is calculated in the css. This way prevent the
override of carbon css.

* Removed an unessacery span.

* Removed an unnecessary span.

* Added the status for the ProgressBarUx

* Remove `style css` and update docs.

* - Fixed the `capped` variable for more readability
- Updated docs `label` and `helperText`
- Updated docs and css

* fix: finished/error states cannot be indeterminate

* Run "yarn build:css"

* Re-run "yarn build:docs"

* test(progress-bar): assert `status` prop

* chore: add aria-busy and set valuenow to 0 when not active

---------

Co-authored-by: Eric Liu <ericyl.us@gmail.com>
Co-authored-by: Enrico Sacchetti <enrico@theetrain.ca>
2023-02-19 12:34:41 -05:00
metonym
6450e8b0b1
fix(types): add missing $$restProps for Checkbox, Filename, FluidForm (#1655)
* fix(types): add missing `$$restProps` for `Checkbox`, `Filename`, `FluidForm`

* Run "yarn build:docs"

* test: assert `$$restProps` for `Checkbox`, `Form`
2023-02-11 13:50:01 -05:00
metonym
d897484abf
fix(dropdown): dispatch correct selectedItem in select event (#1646)
Fixes #1645
2023-02-04 20:31:31 -05:00
ptrxyz
8cb5d538f7
fix(dropdown): fix ssr issue (#1639)
The `onDestroy` hook is also run during SSR, so returning destruction function from `onMount` should do the trick. For #1638
2023-01-24 22:28:36 -05:00
Jonathan Quintin
73aa6e216a
fix(dropdown): close when user clicks outside iframe (#1596)
* `Dropdown` click outside
Fixes #1595

* `onDestroy` we want to remove the event listener
to prevent listeners hanging
2023-01-17 20:57:50 -05:00
metonym
ec867c46ba
fix(tree-view)!: remove expanded property from TreeNode interface (#1631)
* fix(tree-view)!: remove `expanded` property from `TreeNode`

* fix(tree-view-node-list)!: remove unused `expanded` prop

* docs(tree-view): remove `expanded` as a property

#1630
2023-01-17 20:55:46 -05:00
Enrico Sacchetti
6d2e21f027
chore: improve lint, release workflows (#1627)
* Add standard-version to automate releases

* Remove husky

* Add lint script; run lint in GitHub Actions

* Run lint script

* Add Enrico to contributors
2023-01-15 15:34:09 -08:00
Enrico Sacchetti
50066966da
feat(notification)!: replace iconDescription prop with statusIconDescription, closeButtonDescription (#1591)
Fixes #672, fixes #1563

* breaking: remove `iconDescription` prop from `InlineNotification`, `ToastNotification`

* breaking: require `iconDescription` prop in `NotificationIcon`

* feat: add new `statusIconDescription` and `closeButtonDescription` to `InlineNotification`, `ToastNotification`
2022-12-18 15:28:23 -08:00
Enrico Sacchetti
8d55752a18
fix(pagination-nav)!: use 1-indexing to be consistent with Pagination (#1518)
Fixes #1513
2022-12-13 10:23:04 -08:00
Enrico Sacchetti
9198ed5474
feat!: dispatch "change" event in Pagination, rename "change" to "update" in Select (#1497)
Closes #1491

* feat(pagination): dispatch "change" event when interacting with previous/next buttons, page/page size dropdowns

* breaking(select): rename dispatched "change" event to "update"

* breaking(select): forward `change` event to `Select`
2022-12-13 10:22:17 -08:00
metonym
fce92fb648
fix(dropdown): avoid runtime error if items is empty (#1578) 2022-12-07 20:38:22 -08:00
metonym
4b503c8c35
fix(multi-select): avoid runtime error if items is empty (#1577) 2022-12-07 20:34:46 -08:00
Bilux
09b3eed582
fix(combobox): avoid runtime error if items is empty (#1545) 2022-12-07 20:29:04 -08:00
metonym
837716ff8b fix(overflow-menu): dispatch "close" event when clicking outside (#1546)
Fixes #1541
2022-12-07 20:25:47 -08:00
David Wolf
ba62f45d34
fix(table-header): button should have explicit type="button" (#1573) 2022-12-07 20:14:47 -08:00
Maxime Fafard
0f8a57b9d2
fix(popover): fire "click:outside" event when clicking sibling elements (#1570) 2022-12-07 20:10:45 -08:00
Enrico Sacchetti
fa5515ded0
fix(dropdown): only dispatch "select" on interaction, allow arrow keys to navigate menu (#1569)
Fixes #1475
2022-12-07 20:09:29 -08:00
Eric Liu
a0600e8bdb chore(number-input): ensure value is a number
Fast-follow to #1555. `ref.value` remains a string if not converted to a number.
2022-12-07 20:07:49 -08:00
Jonathan Quintin
e6f5766e46
fix(number-input): support floating point values (#1555)
Fixes #233, fixes #486, fixes #1554
2022-12-07 20:06:29 -08:00
Jonathan Quintin
e7fe8ca85b
fix(toggle): forward change, keyup events after toggled updates (#1559)
Fixes #1556
2022-12-07 20:05:20 -08:00
brunnerh
75a69bbfc2
fix(progress-step): fix label text if vertical is true (#1533)
Fixes #1532
2022-12-07 20:03:34 -08:00
brunnerh
7a98ec26eb
fix(progress-step): inherit unclickable styling if preventChangeOnClick is true (#1535)
Fixes #1534
2022-12-07 20:02:24 -08:00
Tadeáš Maršík
bf337c48ae
fix(progress-step): button should have explicit type="button" (#1551)
Fixes #1550
2022-12-07 20:01:29 -08:00
metonym
198e0da4c5
fix(tree-view): loosen TreeNode text property type to any (#1576)
* fix(tree-view): loosen `TreeNode` text property type to any

* Run "yarn build:docs"

* test(tree-view): assert updated property type value
2022-12-07 20:00:20 -08:00
DetachHead
21d841feeb
fix(tree-view): make TreeView children prop type work recursively (#1566) 2022-12-07 19:54:14 -08:00
Bilux
ae34451583
fix(data-table): remove unused import from "svelte/store" (#1529) 2022-10-20 10:21:12 -07:00
metonym
1c4ee00142
fix(search): prop types should extend input attributes (#1523)
Fixes #1520
2022-10-13 22:04:32 -07:00
metonym
c6373dc9b6
fix(a11y): ignore false positive a11y warnings (#1522)
Fixes #1517
2022-10-13 21:37:52 -07:00
Paweł Malinowski
5723ffef02
fix(number-input): allowEmpty should not be invalid if value is null (#1511)
Fixes #1510
2022-10-13 21:24:55 -07:00
metonym
affeb2e2f4
fix(list-box-menu-item): avoid element reference error (#1507)
Fixes #1505
Fixes #1503
2022-10-03 19:08:07 -07:00
metonym
a657b6e334
fix(date-picker): display warn/invalid icons in input with calendar (#1508)
Fixes #1498
2022-10-03 19:07:48 -07:00